What's wrong with my UserDefault code for global Array?

Question

Trying to store an array through UserDefault, but Xcode gives me an error. The error message is Thread 1: Signal SIGABRT, and the console says "NSInvalidArgumentException, reason: Attempt to insert non-property list object". I have previously stored data in the array using this code:

let tempRecipe = GlobalFavorites(recipeImageObject: "", recipeTextObject: "", recipeHeaderObject: "", favoriteRecipeArray: [globalFavoriteRecipes])                 

    tempRecipe.recipeHeaderObject = self.recipeClassArray[self.currentView].recipeHeaderObject      

    tempRecipe.recipeTextObject = self.recipeClassArray[self.currentView].recipeTextObject

    tempRecipe.recipeImageObject = self.recipeClassArray[self.currentView].recipeImageObject

    globalFavoriteRecipes.favoriteRecipeArray.append(tempRecipe)

And that works fine. Here's the code for storing with UserDefault that gives me the error:

UserDefaults.standard.setValue(globalFavoriteRecipes.favoriteRecipeArray, forKey: "savedFavoriteArray")

It's a global array and I want to store the whole array. I guess it has to do with how I write the array in UserDefault, because to me it seems that I'm trying to store something that's not there. Or what am I missing?

BTW - If you look at the documentation for `UserDefaults` you will not see a `setValue(_:forKey:)` method listed. So don't use it. Use one the listed methods for storing a value. — rmaddy, Oct 06 '17 at 21:44
You need to use `set(_:forKey:)` method. `UserDefaults.standard.set(globalFavoriteRecipes.favoriteRecipeArray, forKey: "savedFavoriteArray")` https://developer.apple.com/documentation/foundation/userdefaults/1414067-set — Leo Dabus, Oct 06 '17 at 22:28
@rmaddy he is using a KeyValueCoding method https://developer.apple.com/documentation/objectivec/nsobject/1415969-setvalue — Leo Dabus, Oct 06 '17 at 22:30
@LeoDabus Yes, I know but my point is that they should not be. — rmaddy, Oct 06 '17 at 22:31

score 0 · Answer 1 · answered Oct 06 '17 at 21:53

0

If globalFavoriteRecipes.favoriteRecipeArray is an array of custom objects, you need to make sure you are archiving and unarchiving them properly. Refer to this StackOverflow post.

That post also touches on some other options, as NSUserDefaults isn't the best place to store an array that can potentially grow pretty large, which it sounds like it could in this case based on the variable name.

answered Oct 06 '17 at 21:53

Jake G

1,185
9
19

Thanks, I'll check it out! About array size, it only contain text. Will that be to big to store? What should be used instead? – Joakim Sjöstedt Oct 07 '17 at 06:34

score 0 · Answer 2 · answered Oct 06 '17 at 22:23

0

Use set not setValue:

UserDefaults.standard.set(globalFavoriteRecipes.favoriteRecipeArray, forKey: "savedFavoriteArray")

But, I agree with @Jake, this should only be used to store small amounts of data, not a large array. Happy coding!

answered Oct 06 '17 at 22:23

CodeNinja

616
4
18

What's wrong with my UserDefault code for global Array?

2 Answers2