(bluebird .tap) Can't return data, do wrong

Question

I do:

 return new bluebird((resolve) => {

  bluebird.resolve()
  .tap(saveExcelFiles)
  .tap(...)
  .tap(() => {
      return getZip().then((rows) => {
        resolve(rows) // this outer bluebird helps me
        return rows;
      });
    })
  ;
  
});

How to return all data(for each tap) or just last tap in one bluebird wrap.

P.S. I need sequencing (one by one, tap by tap)

Avoid the [`Promise` constructor antipattern](https://stackoverflow.com/q/23803743/1048572?What-is-the-promise-construction-antipattern-and-how-to-avoid-it)! — Bergi, Oct 09 '17 at 20:26

score 2 · Accepted Answer · answered Oct 09 '17 at 18:06

.tap explicitly means "ignore the return value", if you need the return value - use the standard .then:

.then(() => {
  return getZip().then((rows) => {
    // Nothing outer.
    return rows;
  });
});

Or more compactly:

.then(getZip); // that's it!

Also, you should return the promise chain instead of explicit construction:

return saveExcelFiles().tap(...).then(getZip);

Should suffice for the entire body of your function.

(bluebird .tap) Can't return data, do wrong

1 Answers1