Calling Facebook GraphRequest from another class returns null

Question

I'm making application that requires to get data from Facebook. To avoid duplicating code I decided to create a class for GraphRequest.

public class FacebookRequest {
private static JSONObject object;

private FacebookRequest(JSONObject object) {
    this.object = object;
}

private static JSONObject GraphApiRequest(String path, AccessToken token){
        new GraphRequest(
                token,
                path,
                null,
                HttpMethod.GET,
                new GraphRequest.Callback() {
                    public void onCompleted(GraphResponse response) {
                        object = response.getJSONObject();
                    }
                }
        ).executeAsync();
    return object;
}

public static JSONObject getGraphApi(String path, AccessToken token){
    return GraphApiRequest(path, token);
}}

To call the class I use

private static FacebookRequest fbRequest;
//....
JSONObject object= fbRequest.getGraphApi(path,token);

The problem is GraphApiRequest method always returns object=null and only after that executes request.

What should I change to get actual object on call?

EDIT: Thanks to This answer

So I found a solution to get object on call, but it's not perfect option (maybe even wrong, since I am not very experienced in programming, but it works for me)

public class FacebookRequest {
    private JSONObject object;

    public FacebookRequest(String path, AccessToken token) {
        new GraphRequest(
                token,
                path,
                null,
                HttpMethod.GET,
                new GraphRequest.Callback() {
                    public void onCompleted(GraphResponse response) {
                        object = response.getJSONObject();
                    }
                }
        ).executeAsync();
    }
    public JSONObject getObject(){
        return object;
    }
}

When I am calling request It get's executed after some time

protected void onCreate(Bundle savedInstanceState) {
    //...
    FacebookRequest fbRequest = new FacebookRequest(path,token);
    //...
}

To get actual object on call I use.

JSONObject object = fbRequest.getObject();

It is still not working if I call for a JSONObject right after creating constructor. I am looking forward to improve this code, If you will give me some advice.

You have to wait for the response (you are not waiting becouse of `.executeAsyc()`) and then use the getObject() if you want to get object *right after creating constructor*. It can be done by replacing `.executeAsync()` with `.executeAndWait()` in `FacebookRequest`constructor — Matteo Gaggiano, Oct 24 '17 at 10:32

score 4 · Answer 1 · answered Oct 20 '17 at 07:14

4

Instead of calling.private static FacebookRequest fbRequest; Statically, you should call in the constructor, that way your object will not be null and in return of the response stored in object, you will receive data rather than null.

answered Oct 20 '17 at 07:14

Abdul Ahad

435
4
14

Matteo Gaggiano · Accepted Answer · 2017-10-24T12:18:54.513

4

What you are looking for is explained here (Facebook API how to wait til graphRequest executeAsync is done). As you ask, for use it right after creating constructor replace .executeAsyc() with .executeAndWait().

This is not adviced due a freeze on main thread and a bad user experience.

edited Oct 24 '17 at 12:18

answered Oct 24 '17 at 10:37

Matteo Gaggiano

1,254
15
28

Yes @Matteo you are right I also had the same problem and I solved with this solution. – Sejal Baraiya Oct 25 '17 at 11:25

score 1 · Answer 3 · answered Oct 18 '17 at 11:45

1

why don't you follow https://developers.facebook.com/docs/android/graph/ this documentation and use this method GraphRequest.newMeRequest()

answered Oct 18 '17 at 11:45

avez raj

2,055
2
22
37

What I mentioned in my question was "To avoid duplicating code I decided to create a class for GraphRequest." I have no problems to get data in activity. What I want to achieve is to get JSONObject from any class, just by calling `JSONObject object= fbRequest.getGraphApi(path,token); `without making new request function. – Markus Oct 18 '17 at 15:26

Calling Facebook GraphRequest from another class returns null

3 Answers3