3

I have a shell script cron which calls a python script from same directory but when this cron is executing, i am not getting expected output from my python script and when i execute it manually my python script's output is as expected.

I have provided python script paths like /usr/bin/python room_wise.py

and given all shell params in shell script as well but still my python script is not called using the shell script cron.

Can anyone help me here?

Sid
  • 57
  • 1
  • 6

1 Answers1

3

The big issue in cron jobs is the absolute directory locations and relative directory locations. You need to split the relative path out firstly as shown.

#!/usr/bin/env bash
dirName=`dirname $0`
baseName=`basename $0`
arg1=$1
arg2=$2
cd ${dirName} && python ./room_wise.py arg1 arg2

Then use crontab -e to add items to your user cron jobs and add the following:

PATH=/usr/bin:/bin:/sbin
30 00 * * * /my/directory/containing/room_wise_py.sh arg1 arg2 > /my/directory/containing/output.log 2>&1

You can see that I've added the PATH since this can sometimes be a problem with certain Operating system distributions. Also, the script exists in the same directory as the bash script, or you can pass the directory location as an argument if you modify the bash script to include dirname as $1.

Also you can see that I've directed all output to a log file. This is a really good idea since its sometimes very difficult to debug the process if something goes wrong.

Eamonn Kenny
  • 1,926
  • 18
  • 20
  • Remember to add #!/usr/bin/env python at the start of your python script if you haven't already done this. This is also an important aspect to get right when executing software from bash scripts in cron. – Eamonn Kenny Oct 13 '17 at 11:44
  • 1
    what does the line `2>&1` do at the end of the pipe? – 3pitt Feb 09 '18 at 17:20
  • @3pitt it is also redirecting the error output to the log file which was previous specified – Leland Hepworth Oct 30 '20 at 21:14