new activity not starting (app has stopped)

Question

I want to open a new activity by clicking on cardview(item) in Recyclerview. But my new activity is unable to start and application has stopped pops up

My adapter class is

public class MyAdapter extends RecyclerView.Adapter<MyAdapter.ViewHolder>{

private List<Contacts> listitems;
private Context context;

public interface OnItemClickListener{
    void onItemClick(Contacts item);
}

public MyAdapter(List<Contacts> listitems, Context context) {
    this.listitems = listitems;
    this.context = context;
}

@Override
public MyAdapter.ViewHolder onCreateViewHolder(ViewGroup parent, int viewType) {
    View v = LayoutInflater.from(parent.getContext()).inflate(R.layout.list_item,parent,false);
    return new ViewHolder(v);
}

@Override
public void onBindViewHolder(MyAdapter.ViewHolder holder, int position) {
    Contacts c = listitems.get(position);

    holder.t1.setText(c.getName());
    holder.t2.setText(c.getNumber());

}

@Override
public int getItemCount() {
    return listitems.size();
}

public class ViewHolder extends RecyclerView.ViewHolder implements View.OnClickListener {
    public TextView t1,t2;
    public ImageView image;

    public ViewHolder(View itemView) {
        super(itemView);

        itemView.setOnClickListener(this);

        t1 = (TextView) itemView.findViewById(R.id.textview1);
        t2 = (TextView) itemView.findViewById(R.id.textview2);

    }

    @Override
    public void onClick(View v) {
        itemView.getContext().startActivity(new Intent(context,Details.class));
    }
}
}

Post the error that you are receiving in your android monitor. — emilpmp, Oct 15 '17 at 12:23
android monitor doesnt showing any errors just app is crashing as i click on item — Omar Saleem, Oct 15 '17 at 12:29
Why are you using itemview.setOnClickListener? You can give id to your root layout and perform on click listener on it — emilpmp, Oct 15 '17 at 13:43

score 0 · Answer 1 · answered Oct 15 '17 at 11:29

0

just replace

itemView.getContext().startActivity(new Intent(context,Details.class));

with

context.startActivity(new Intent(context,Details.class));

answered Oct 15 '17 at 11:29

sourabh kaushik

523
4
20

i did as you said but it didnt help :( – Omar Saleem Oct 15 '17 at 11:35
is it showing some error or just crashing the application if it is just crashing ? – sourabh kaushik Oct 15 '17 at 11:40
then error is in Details.class not in this class – sourabh kaushik Oct 15 '17 at 11:40
not showing any error just crashing :( – Omar Saleem Oct 15 '17 at 12:08
1

i just found out , i did not register the new class and its layout (new activity) in manifest btw thanks :) – Omar Saleem Oct 15 '17 at 18:32
Check whether the activity you are opening is defined in manifest file Also post error log showing in Android Monitor – Satender Kumar Oct 19 '17 at 04:13

sourabh kaushik · Answer 2 · 2017-10-19T04:06:37.027

0

you are using recycler view then you can use this in your activity not in adapter

recyclerview.onaddOnItemTouchListener(new RecyclerItemClickListener(this, new RecyclerItemClickListener.OnItemClickListener() {
    @Override
    public void onItemClick(View view, int position) {
      Activity_name.startActivity(new Intent(context,Details.class));
    }
}));

edited Oct 19 '17 at 04:06

answered Oct 15 '17 at 12:20

sourabh kaushik

523
4
20

you have to remove onclicklistener from the adapter – sourabh kaushik Oct 15 '17 at 12:23
Have you defined activity in manifest file, if defined then share the error logs – Satender Kumar Oct 19 '17 at 04:14

new activity not starting (app has stopped)

2 Answers2