Unable to download file from s3 using return response()->download($file);

Question

I am uploading files tos3 I want it to download securely using following code in my controller, but it's not working.

I am using Laravel 5.5 and files visibility is not public on s3.

if( Storage::disk('s3')->exists($file_path) ) {
      $file =  Storage::disk('s3')->get($file_path);
      return response()->download($file);
}

abort(404, 'File not found.');

It's giving me this error

is_file() expects parameter 1 to be a valid path, string given
...
/home/vagrant/spark-etr/vendor/symfony/http-foundation/File/File.php:36
#1 /home/vagrant/spark-etr/vendor/symfony/http-foundation/File/File.php(36): is_file('\\xFF\\xD8\\xFF\\xE0\\x00\\x10JFIF\\x00\\x01\\x01\\x00\\x00...')
#2 /home/vagrant/spark-etr/vendor/symfony/http-foundation/BinaryFileResponse.php(94): Symfony\\Component\\HttpFoundation\\File\\File->__construct('\\xFF\\xD8\\xFF\\xE0\\x00\\x10JFIF\\x00\\x01\\x01\\x00\\x00...')
#3 /home/vagrant/spark-etr/vendor/symfony/http-foundation/BinaryFileResponse.php(53): Symfony\\Component\\HttpFoundation\\BinaryFileResponse->setFile('\\xFF\\xD8\\xFF\\xE0\\x00\\x10JFIF\\x00\\x01\\x01\\x00\\x00...', 'attachment', false, true)
#4 /home/vagrant/spark-etr/vendor/laravel/framework/src/Illuminate/Routing/ResponseFactory.php(125): Symfony\\Component\\HttpFoundation\\BinaryFileResponse->__construct('\\xFF\\xD8\\xFF\\xE0\\x00\\x10JFIF\\x00\\x01\\x01\\x00\\x00...', 200, Array, true, 'attachment')

The file is on s3 since I am checking for exists before downloading.

Update

Dumping the $file var gives me binary like this

Please help

What do you get when you call dd($file);? – Norris Oduro Oct 16 '17 at 04:46 — Norris Oduro, Oct 16 '17 at 04:46
it gives me binary data, looks like file itself – Saqueib Oct 16 '17 at 04:46 — Saqueib, Oct 16 '17 at 04:46
what is the content type of the `file`? – Norris Oduro Oct 16 '17 at 04:54 — Norris Oduro, Oct 16 '17 at 04:54

Norris Oduro · Accepted Answer · 2017-10-16T05:06:01.297

5

Try

if( Storage::disk('s3')->exists($file_path) ) {
      $file =  Storage::disk('s3')->get($file_path);

      $headers = [
        'Content-Type' => 'your_content_type', 
        'Content-Description' => 'File Transfer',
        'Content-Disposition' => "attachment; filename={$yourFileName}",
        'filename'=> $yourFileName
     ];

    return response($file, 200, $headers);
}

Update

You can read more about downloading large files Why don't large files download easily in Laravel?

edited Oct 16 '17 at 05:06

answered Oct 16 '17 at 04:57

Norris Oduro

1,019
8
17

this is working but file size can go upto 100mb or more, will it be efficent. I am afread it will give `PHP Fatal error: Allowed memory size of 5242880 bytes exhausted` – Saqueib Oct 16 '17 at 05:02
Im not sure you will ever see that :) – Norris Oduro Oct 16 '17 at 05:03
@Saqueib i have pasted a link to help you with `large` files – Norris Oduro Oct 16 '17 at 05:06
Dont u also need to include Content-Length? – Neel Sep 10 '19 at 07:36

score 2 · Answer 2 · answered Oct 16 '17 at 04:56

Build the response yourself:

    $file = ''; // what you got from S3
    $mimeType = 'text/plain'; // or whatever the mime type is
    $fileName = 'example.txt';

    $headers = [
        'Content-type'        => $mimeType,
        'Content-Disposition' => 'attachment; filename="' . $fileName . '"',
        'Content-Length'      => sizeof($file),
    ];

    return response($file, 200, $headers);

... or research on how to download streams.

Unable to download file from s3 using return response()->download($file);

Update

2 Answers2