Multiple Else If expecting a statement in C?

Question

So I'm asking the user for date of birth, and based on that I will output them a short sentence based on their zodiac. I can't seem to find any information on how to correctly proceed with this, or how I should go on about switch statements in this case. Any help is greatly appreciated!

int dateOfBirth;

// initiate zodiac animals year of birth
int rat = 2008 || 1996 || 1984 || 1972 || 1960;
int ox = 2009 || 1997 || 1985 || 1973 || 1961;
int tiger = 2010 || 1998 || 1986 || 1974 || 1962;
int rabbit = 2011 || 1999 || 1987 || 1975 || 1963;
int dragon = 2012 || 2000 || 1988 || 1976 || 1964;
int snake = 2013 || 2001 || 1989 || 1977 || 1965;
int horse = 2014 || 2002 || 1990 || 1978 || 1966;
int goat = 2015 || 2003 || 1991 || 1979 || 1967;
int monkey = 2016 || 2004 || 1992 || 1980 || 1968;
int rooster = 2017 || 2005 || 1993 || 1981 || 1969;
int dog = 2019 || 2007 || 1995 || 1983 || 1971;
int pig = 2019 || 2007 || 1995 || 1983 || 1971;


// ask user for date of birth
printf("Please enter your date of birth: \n");
scanf_s("%d", &dateOfBirth);


// FORTUNE IF STATEMENTS
// im tired of these motherfluffing IF STATEMENTS ON MY MOTHERFLUFFING SCREEN!

// rat
if (dateOfBirth == 2008 || 1997 || 1984 || 1972 || 1960)
{
    printf("Jerry?%d\n", rat);
}
//ox
elseif(dateOfBirth == 2009 || 1997 || 1985 || 1973 || 1961);
{
    printf("Nice horns m8");
}
// tiger
elseif(dateOfBirth == 2010 || 1998 || 1986 || 1974 || 1962);
{
    printf("RAAWR\n");
}
// rabbit
elseif(dateOfBirth == 2011 || 1999 || 1987 || 1975 || 1963);
{
    printf("HOP HOP HOP %d", rabbit);
}
// dragon
elseif(dateOfBirth == 2012, 2000, 1988, 1976, 1964);
{
    printf("RYUJIN NO KEN WO KURAE!");
}
// snake
elseif(dateOfBirth == 2013, 2001, 1989, 1977, 1965);
{
    printf("Orochimaru?");
}
// horse
elseif(dateOfBirth == 2014, 2002, 1990, 1978, 1966);
{
    printf("NOW WATCH ME NE- No.");
}
// goat 
elseif (dateOfBirth == 2015, 2003, 1991, 1979, 1967);
{
    printf("Cheese.");
}
// monkey
elseif (dateOfBirth == 2016, 2004, 1992, 1980, 1968);
{
    printf("You sure you're not genetically engineered...?");
}
// rooster 
elseif (dateOfBirth == 2017, 2005, 1993, 1981, 1969);
{
    printf("Who needs an alarm clock amarite?");
}
// dog
elseif (dateOfBirth == 2018, 2006, 1994, 1982, 1970);
{
    printf("Haha, funny doggo!");
}
// pig
else (dateOfBirth == 2019, 2007, 1995, 1983, 1971);
{
    printf("I don't even like bacon.");
}

system("pause");

}

I hope the code I included is correct, as in formatting.

Edit: elseif -> else if. Also no semicolon at the end of arguments, as well as adding "dateOfBirth ==" to each year, code now working fine thanks all for input especially @Vlad From Moscow!

`int rat = 2008 || 1996 || 1984 || 1972 || 1960;` is incorrect. As is `if (dateOfBirth == 2008 || 1997 || 1984 || 1972 || 1960)` — Weather Vane, Oct 22 '17 at 12:49
`dateOfBirth == 2008 || 1997 || 1984 || 1972 || 1960` is also `1`. — melpomene, Oct 22 '17 at 12:49
There's no `elseif` construct, you mean `else if`. There's a lot wrong with this code, you should probably [read a good book](https://stackoverflow.com/questions/388242/the-definitive-c-book-guide-and-list). — hnefatl, Oct 22 '17 at 12:50
You can't have `printf("Please enter your date of birth: \n");` outside of any function. — melpomene, Oct 22 '17 at 12:50
Read a book - a rational book on C. 2) Am a dog or a pig? 1971? — Ed Heal, Oct 22 '17 at 12:51
Also `if(dateOfBirth == 2012, 2000, 1988, 1976, 1964);` is inconsistent but again wrong, and, you should remove all the `;` after a conditional test. — Weather Vane, Oct 22 '17 at 12:52

score 1 · Accepted Answer · answered Oct 22 '17 at 12:53

1

For starters there is no elseif statement in C++.There are if and if-else statements in C++.

Also you have to remove mistaken semicolons at the end of if or else with if statements.

And the conditions are also written incorrectly.

A valid else statement can look for example like

else if ( dateOfBirth == 2009 || dateOfBirth == 1997 || dateOfBirth == 1985 || dateOfBirth == 1973 || dateOfBirth == 1961 )
{ 
//...
}

answered Oct 22 '17 at 12:53

Vlad from Moscow

301,070
26
186
335

I'm sorry! I meant else if, the elseif was me trying to figure it out after someone said maybe trying that out... And also can't believe I missed the == for every variable. Thanks. I'll try this out. – Deni Oct 22 '17 at 13:02

Multiple Else If expecting a statement in C?

1 Answers1