C# program that reads in texts until you press a key and then prints it out

Question

    string text;
    string alltext; //what do I do with this?
    do
    {
        text = Console.ReadLine();
    } while (text!="x");
    Console.WriteLine(text);
    Console.ReadKey();

What did I do wrong? Someone on Reddit said that I need another variable to hold all the texts in, but I have no idea how to do it.

Read this: https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/operators/addition-assignment-operator — hatchet - done with SOverflow, Oct 23 '17 at 14:33
problem is non of these stop on pressing x, they all need a line with x on its own and pressing enter — BugFinder, Oct 23 '17 at 14:34
better question is does he know how to declare a variable..? this is not that difficult.. store all the vales into a List and when someone enters the letter To UpperCase `X` , then uses `Console,WriteLine(string.Join(" ", "Your List")` varible... — MethodMan, Oct 23 '17 at 14:35

abr · Accepted Answer · 2017-10-23T14:45:01.157

2

I believe you're new to programming, so I'll try to explain what you want to do.

You want to store everything you type into a variable until you press X (or so I've understood).

The variable 'key' will store whatever you type once a cycle (can be anything) - meaning, key will always have a volatile value, because you are changing it everytime it reaches the readline. You append the variable 'key' to your other variable, 'alltext', that is where you have it's previous value + the new value 'key'. The cycle only ends when you enter 'x' and only 'x'. After that, it will print everything in 'alltext'.

There are many ways to do this, and working with an array is a better and cleaner way, however I'm just adapting what you wrote in a way that you can easily understand.

string key = "";
string alltext = "";
do
{
    key = Console.ReadLine();
    alltext += key + "\n ";
} while (key!="x");
Console.WriteLine(alltext);
Console.ReadKey();

What I'm doing with "\n" is that I'm adding a new line after that text (let the console know its a new line).

Let me know if this helps

edited Oct 23 '17 at 14:45

answered Oct 23 '17 at 14:32

abr

2,071
22
38

Code only answers are considered lower quality. Consider adding an explanation to flesh your answer out and improve its long-term value. – Oct 23 '17 at 14:32
@Amy true, was editing as you posted it :p – abr Oct 23 '17 at 14:36
updated @FakeCaleb – abr Oct 23 '17 at 14:39
Doesn't work. Inside the loop it says that "alltext"=Use of unassigned local variable. – lapartman Oct 23 '17 at 14:44
@lapartman Updated, what was wrong was that the variable 'alltext' didn't have an initial value, so the first 'alltext += key + "\n ";' would give an error. Thanks for pointing it out – abr Oct 23 '17 at 14:45
Thank you, it's working! I understand it now! – lapartman Oct 23 '17 at 14:48
@lapartman you're welcome – abr Oct 23 '17 at 14:48
I don't know why I got downvoted so fast lol. – lapartman Oct 23 '17 at 14:51
Try re-writing the question in a way that makes it within the ruleset the people declared above, and good luck programming! – abr Oct 23 '17 at 14:53

mcalex · Answer 2 · 2017-10-24T04:48:00.923

1

Think about what you are trying to do: create a string, and keep adding lines to it, until the user hits 'x'.

Now look at what you are doing: creating a string and then creating that string again with every new line the user types.

Work out what syntax you need to append (add) to the string. Hint: look up concatenate.

edited Oct 24 '17 at 04:48

answered Oct 23 '17 at 14:34

mcalex

6,628
5
50
80

Ngine · Answer 3 · 2017-10-23T14:51:49.067

0

    string text="";
    string alltext=""; //what do I do with this?
    while (text!="x" || text!="X")
    {
        text = Console.ReadLine();
        alltext+=text;
    } 
    Console.WriteLine(alltext);
    Console.ReadKey();

You mean this ?

edited Oct 23 '17 at 14:51

answered Oct 23 '17 at 14:36

Ngine

65
8

You need to initialize alltext – abr Oct 23 '17 at 14:47
Fixed in a second. Are you new to programming ?. If yes this could be helpful for you: http://www.learncs.org/ – Ngine Oct 23 '17 at 14:49
@FakeCaleb <3 :) – Ngine Oct 23 '17 at 14:52
@Ngine learncs.org maybe? Removed the downvote :) – FakeCaleb Oct 23 '17 at 14:53

C# program that reads in texts until you press a key and then prints it out

3 Answers3