No JSON output?

Question

I am writing a currency exchange android app however when the app is run I do not seem to get a response from the API.

API LINK 1) https://restcountries.eu/rest/v2/all

MainActivity Code:

 import android.os.AsyncTask;
 import android.support.v7.app.AppCompatActivity;
 import android.os.Bundle;
 import android.util.Log;
 import android.view.View;
 import android.widget.Button;

 import org.json.JSONArray;
 import org.json.JSONException;
 import org.json.JSONObject;

 import java.io.IOException;
 import java.io.InputStream;
 import java.io.InputStreamReader;
 import java.net.HttpURLConnection;
 import java.net.MalformedURLException;
 import java.net.URL;
 import java.util.ArrayList;

 import static java.lang.reflect.Modifier.FINAL;

 public class MainActivity extends AppCompatActivity {


//Fill spinner with values from this URL - https://restcountries.eu/rest/v2/all

final String CURRENCY_DATA = "https://restcountries.eu/rest/v2/all";

ArrayList<String> currency_list = new ArrayList();

Button btn;

//The amount entered x's by the curreny exchange rate..

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);

    btn = (Button) findViewById(R.id.button);

    btn.setOnClickListener(new View.OnClickListener() {
        @Override
        public void onClick(View view) {

            new downloadData().execute();

            new downloadExchangeRate().execute();

        }
    });

}




public class downloadData extends AsyncTask<String, Void, String> {

    String result = "";



    @Override
    protected String doInBackground(String... strings) {


        try {
            URL url = new URL(CURRENCY_DATA);
            HttpURLConnection httpURLConnection= (HttpURLConnection) url.openConnection();
            httpURLConnection.connect();
            InputStream inputStream = httpURLConnection.getInputStream();
            InputStreamReader inputStreamReader = new InputStreamReader(inputStream);

            int data = inputStreamReader.read();

            while (data != -1) {

                char current = (char) data;

                result += current;

                data = inputStreamReader.read();
            }

        } catch (MalformedURLException e) {
            e.printStackTrace();
        } catch (IOException e) {
            e.printStackTrace();
        }
        return result;
    }

    @Override
    protected void onPostExecute(String s) {

        try {
            JSONObject jsonObject = new JSONObject(result);
            JSONArray jsonArray = jsonObject.getJSONArray("currencies");


            for (int i =0; i<jsonArray.length(); i++){


                currency_list.add(jsonArray.getJSONObject(i).optString("code"));

                Log.d("list", currency_list.toString());

            }
        } catch (JSONException e) {
            e.printStackTrace();
        }

        super.onPostExecute(s);
    }
}



 }

downloadExchangeRate.java code:

import android.os.AsyncTask;
import android.util.Log;

import org.json.JSONArray;
import org.json.JSONException;
import org.json.JSONObject;

import java.io.IOException;
import java.io.InputStream;
import java.io.InputStreamReader;
import java.net.HttpURLConnection;
import java.net.MalformedURLException;
import java.net.URL;
import java.util.ArrayList;


public class downloadExchangeRate extends AsyncTask<String,Void,String> {


String result = "";

@Override
protected String doInBackground(String... strings) {

    final String EXCHANGE_RATE = "http://api.fixer.io/latest";

    try {
        URL url = new URL(EXCHANGE_RATE);
        HttpURLConnection httpURLConnection= (HttpURLConnection) url.openConnection();
        httpURLConnection.connect();
        InputStream inputStream = httpURLConnection.getInputStream();
        InputStreamReader inputStreamReader = new InputStreamReader(inputStream);

        int data = inputStreamReader.read();

        while (data != -1) {

            char current = (char) data;

            result += current;

            data = inputStreamReader.read();
        }

    } catch (MalformedURLException e) {
        e.printStackTrace();
    } catch (IOException e) {
        e.printStackTrace();
    }
    return result;
}


@Override
protected void onPostExecute(String s) {

    JSONObject jsonObject = null;
    try {
        jsonObject = new JSONObject(result);

    for (int i = 0; i<jsonObject.length(); i++){

        ArrayList<String> rates = new ArrayList<>();
        rates.add(jsonObject.optString("rates"));

        Log.d("list", rates.toString());

    }

    } catch (JSONException e) {
        e.printStackTrace();
    }




    super.onPostExecute(s);


}
}

Any help is appreciated, I think I am calling the JSON wrong.

Now is the best time to figure out how to debug this small program. https://ericlippert.com/2014/03/05/how-to-debug-small-programs/ — , Oct 23 '17 at 16:23

Mukesh M · Answer 1 · 2017-10-23T17:40:54.107

Update Code as:

Use StringBuilder for result (Why? See this https://stackoverflow.com/a/14927864/5227589):

StringBuilder result=new StringBuilder();
...
......
result.append(current);

When using String it will take very long time to complete while loop due to use of result += current;: .

When using StringBuilder:

In onPostExecute

JSONArray jsonArray = new JSONArray(result.toString());

                for (int i =0; i<jsonArray.length(); i++){

                    currency_list.add(jsonArray.getJSONObject(i).getJSONArray("currencies").getJSONObject(0).optString("code"));

                    //Log.d("list", currency_list.toString());

                }

Full Code:

 public class downloadData extends AsyncTask<String, Void, String> {

        StringBuilder result=new StringBuilder();



        @Override
        protected String doInBackground(String... strings) {


            try {
                URL url = new URL(CURRENCY_DATA);
                HttpURLConnection httpURLConnection= (HttpURLConnection) url.openConnection();
                httpURLConnection.connect();
                InputStream inputStream = httpURLConnection.getInputStream();
                InputStreamReader inputStreamReader = new InputStreamReader(inputStream);

                int data = inputStreamReader.read();
                char current = (char) data;
                Log.i("data",current+"");
                while (data != -1) {

                    current = (char) data;

                    result.append(current);

                    data = inputStreamReader.read();
                  //  Log.i("data",current+"");
                }
                //Log.i("data",result+"");

            } catch (IOException e) {
                e.printStackTrace();
            }
            return result.toString();
        }

        @Override
        protected void onPostExecute(String s) {

            try {
                JSONArray jsonArray = new JSONArray(result.toString());

                for (int i =0; i<jsonArray.length(); i++){

                    currency_list.add(jsonArray.getJSONObject(i).getJSONArray("currencies").getJSONObject(0).optString("code"));

                    //Log.d("list", currency_list.toString());

                }
                Log.d("list", currency_list.toString());
            } catch (JSONException e) {
                e.printStackTrace();
            }

            super.onPostExecute(s);
        }
    }

No JSON output?

1 Answers1