PHP Cannot modify header information - using input form

Question

My code is throwing the following error:

Warning: Cannot modify header information - headers already sent by (output started at /Users/johns/Desktop/Test/index.php:5) in /Users/johns/Desktop/Test/index.php on line 7

The actual code issue seems to be here:

<?php
if (isset($_GET["googlesearch"])) {
    header("Location: https://www.test.com/#!q=" . $_GET["googlesearch"] . "&page=0&refinements=%5B%5D&numerics_refinements=%7B%7D&index_name=%22_default_products%22");
    exit;
}
?>

My full page code is :

<!--
     This is the minimum valid AMP HTML document. Just type away
     here and the AMP Playground will render your document on the fly.
-->
 <?php
if (isset($_GET["googlesearch"])) {
    header("Location: https://www.test.com/#!q=" . $_GET["googlesearch"] . "&page=0&refinements=%5B%5D&numerics_refinements=%7B%7D&index_name=%22_default_products%22");
    exit;
}
?>
<!doctype html>
<html ⚡>
<head>
  <meta charset="utf-8">
  <link rel="canonical" href="self.html" />
  <meta name="viewport" content="width=device-width,minimum-scale=1">
  <style amp-boilerplate>body{-webkit-animation:-amp-start 8s steps(1,end) 0s 1 normal both;-moz-animation:-amp-start 8s steps(1,end) 0s 1 normal both;-ms-animation:-amp-start 8s steps(1,end) 0s 1 normal both;animation:-amp-start 8s steps(1,end) 0s 1 normal both}@-webkit-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@-moz-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@-ms-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@-o-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}</style><noscript><style amp-boilerplate>body{-webkit-animation:none;-moz-animation:none;-ms-animation:none;animation:none}</style></noscript>
  <script async src="https://cdn.ampproject.org/v0.js"></script>
  <!-- Custom CSS -->
  <style amp-custom>
    <?php include './components/skin/style/css/base.css'; ?>
  </style>
</head>
<body>
  <!-- Search bar -->
  <div class="sidebar">

    <form method="GET"
          class="p2"
          action="<?php echo $_SERVER['PHP_SELF']; ?>"
          target="_top">
        <div class="ampstart-input inline-block relative mb3">
            <input type="search"
                   placeholder="Search..."
                   name="googlesearch">
        </div>
        <input type="submit"
               value="OK"
               class="ampstart-btn caps">
    </form>

  </div>
</body>
</html>

I have tried placing ob_start(); on multiple places but with no luck. Can someone help?

Alternatively, and sometimes more securely, you can move the content into a PHP comment. — chris85, Oct 23 '17 at 20:39

mega6382 · Accepted Answer · 2017-10-23T20:34:48.770

3

Remove all this:

<!--
     This is the minimum valid AMP HTML document. Just type away
     here and the AMP Playground will render your document on the fly.
-->

From Before this:

<?php
if (isset($_GET["googlesearch"])) {
    header("Location: https://www.test.com/#!q=" . $_GET["googlesearch"] . "&page=0&refinements=%5B%5D&numerics_refinements=%7B%7D&index_name=%22_default_products%22");
    exit;
}
?>

There is a space before <?php remove that too. If any output is sent before headers it will give error.

edited Oct 23 '17 at 20:34

answered Oct 23 '17 at 20:33

mega6382

9,211
17
48
69

Great, that seems to fix the issue – John Oct 23 '17 at 20:34
1

@GrumpyCrouton They are html comments they are part of the output, they will cause error. – mega6382 Oct 23 '17 at 20:36
@mega6382 Hmm, I just tested it on my server and it worked. I think it's something weird with my server though, as having the space there also doesn't break it. Thanks guys! – GrumpyCrouton Oct 23 '17 at 20:38
Yeah, I tested it on my localhost it worked, but on a remote server of mine it gave error. – mega6382 Oct 23 '17 at 20:45

PHP Cannot modify header information - using input form

1 Answers1