I need help for a Yes/No function for my program

Question

The (char n) would be receive either a "Y" or a "N" from the user.

bool YesNo(char n) //Prototype Function
{
    if (n == "Y")
        return 1; // true
    else
        return 0; //false
}

`"Y"` is not a `char`, it is a `const char[2]`. You might want to read a [good book](https://stackoverflow.com/questions/388242/the-definitive-c-book-guide-and-list). — Rakete1111, Oct 26 '17 at 19:51
"//Prototype Function" - it's not a prototype, it's a definition. And you want `'Y'`, not `"Y"`. — , Oct 26 '17 at 19:51
Please see: [Why is “Can someone help me?” not an actual question?](http://meta.stackoverflow.com/q/284236) — EJoshuaS - Stand with Ukraine, Oct 26 '17 at 19:55
If you are returning `bool`, then return the correct values: `true` or `false`, not 0 or 1. — Thomas Matthews, Oct 26 '17 at 20:36
You could use one statement: `return (std::tolower(n) == 'y');`. — Thomas Matthews, Oct 26 '17 at 20:38

score 2 · Answer 1 · answered Oct 26 '17 at 19:53

2

You are not comparing char, instead you are comparing a string. A char can be compared in following way -

if (n == 'Y')

Just use a single quote for character and double quote for string. Change your if condition as above. It'll work fine.

answered Oct 26 '17 at 19:53

Naseef Chowdhury

1 Answers1