Internet connection issue

Question

In my app I am checking internet connection with below method :

public static boolean isOnline(Context context) {
    ConnectivityManager cm = (ConnectivityManager) context.getSystemService(Context.CONNECTIVITY_SERVICE);
    NetworkInfo netInfo = cm.getActiveNetworkInfo();
    if (netInfo != null && netInfo.isConnectedOrConnecting()) {
        return true;
    }
    return false;
}

Now, in activity I am checking for internet connection as below :

if (Constant.isOnline(mContext))
   loadNotificationList();
else
   Constant.displayToast(mContext, getResources().getString(R.string.msg_internet));

Now, If MobileData or wi-fi is off I am getting toast message. It's fine. But, the issue is in below scenario :

==> I am using wi-fi of another device in which hotspot is on and my device got connected to it. now, I have turned off the mobile data of that another device. that means: no internet access for me. But, still i am getting true from the method : isOnline()

so, I think the method is checking for the state only. What if I wanna go check that internet access is available in real or not?

Thanks.

You are only checking if you have a wifi connection. And as you have discovered that is not yet an internet connection. — greenapps, Nov 01 '17 at 10:10

score 1 · Answer 1 · answered Nov 01 '17 at 10:49

I had used the below approach for my project. I made a class CheckInternet. The idea is to check if you're connected to any network using isNetworkAvailable() If so, then checking for internet connectivity by pinging a server and checking for response (preferable Google) in hasActiveInternetConnection()

import android.content.Context;
import android.net.ConnectivityManager;
import android.net.NetworkInfo;
import android.util.Log;

import java.io.IOException;
import java.net.HttpURLConnection;
import java.net.URL;

public class CheckInternet {

    private static final String TAG = CheckInternet.class.getSimpleName();
    protected Context context;

    public CheckInternet(Context context) {
        this.context = context;
    }

    private static boolean isNetworkAvailable(Context context) {
        ConnectivityManager connectivityManager = (ConnectivityManager) context.getSystemService(Context.CONNECTIVITY_SERVICE);
        NetworkInfo activeNetworkInfo = connectivityManager.getActiveNetworkInfo();
        return activeNetworkInfo != null && activeNetworkInfo.isConnected();
    }

    public static boolean hasActiveInternetConnection(Context context) {
        if (isNetworkAvailable(context)) {
            try {
                HttpURLConnection urlc = (HttpURLConnection) (new URL("http://clients3.google.com/generate_204").openConnection());
                urlc.setRequestProperty("User-Agent", "Test");
                urlc.setRequestProperty("Connection", "close");
                urlc.setConnectTimeout(1500);
                urlc.connect();

                return (urlc.getResponseCode() == 204 && urlc.getContentLength() == 0);
            } catch (IOException e) {
                Log.e(TAG, "Error checking Internet Connection - " + e);
            }
        } else {
            Log.d(TAG, "No network available!");
        }
        return false;
    }
}

You call this class anywhere via a Thread (since calling it directly would throw a NetworkOnMainThreadException ). Below is how I called it in a Fragment.

Thread th = new Thread(new Runnable() {
    public void run() {
        Boolean b = CheckInternet.hasActiveInternetConnection(getContext());

        if (b) {
            //Net is working, do whatever
        } else {
            //Net is NOT working
        }
    }
});
th.start();

IntelliJ Amiya · Answer 2 · 2017-11-01T10:46:34.467

0

If MobileData or wi-fi is off I am getting toast message

 if (netInfo != null && netInfo.isConnectedOrConnecting()) {
        return true;
    }

Problem

Your return type

You should try this way,

 public static boolean isOnline(Context context) 
        {
        ConnectivityManager cm = (ConnectivityManager) context.getSystemService(Context.CONNECTIVITY_SERVICE);
        NetworkInfo netInfo = cm.getActiveNetworkInfo();
            if (netInfo == null)
                return false;
            if (!netInfo.isConnected())
                return false;
            if (!netInfo.isAvailable())
                return false;
        return true;
       }

edited Nov 01 '17 at 10:46

answered Nov 01 '17 at 10:21

IntelliJ Amiya

74,896
15
165
198

1

Isn't the condition `if(netInfo !=null && netInfo.isConnected()) return true; else return false;` enough for this answer – Yasin Kaçmaz Nov 01 '17 at 10:27
You all are not getting my point. I have already done these stuffs. Read the question again. – Mashuk Khan Nov 01 '17 at 10:45

score 0 · Answer 3 · answered Nov 01 '17 at 10:35

Below method for Network is available or not.

    public static boolean isNetworkAvailable(Context mContext) {

    ConnectivityManager cm = (ConnectivityManager) mContext
            .getSystemService(Context.CONNECTIVITY_SERVICE);
    NetworkInfo networkInfo = cm.getActiveNetworkInfo();
    if (networkInfo != null && networkInfo.isConnected()) {
        Log.e("Network Testing", "***Available***");
        return true;
    }
    Log.e("Network Testing", "***Not Available***");
    return false;
}

in activity checking for internet connection.

  if(Utils.isNetworkAvailable(mContext)){

        isInternetAvailable = true;

    }else{
        isInternetAvailable = false;
    }

Internet connection issue

3 Answers3