Can't enter data for all days and accumulate a total

Question

I am running in to an error which doesn't let me insert all of the required data. I am sure I have my for loops set up correctly. I'm not exactly sure on what I'm missing but if someone can over look my code, I would highly appreciate it!

I am using Dev C++.

#include <stdio.h>




    float loadArray(float *) ; 

    float calcTotal(float *); // calc total sales

    int main()
    {
   //declare variables

   float sales[7];
   float weeklyS;
   float total;
float totalS;
float highest;

//since these are pointers in the func, u need an &
sales[7] = loadArray(&weeklyS);

total = calcTotal(&totalS);     // when calling a pointer use a & to send the address
printf("Total of the week is: %.2f",totalS);

//calcHighest(odom,odom2,milesDrvn,avgMPG);


return 0 ;  

}



float loadArray(float *weeklyS)   
{
float sales;
int x;

for ( x = 0; x < 7; x++)
{

// have user enter the following
printf("Enter sales for day %d: ",x  + 1);
scanf("%d",&*weeklyS);

}

return sales;
}


float calcTotal(float *totalS)
{

float total = 0 ; 
int x;

for ( x = 0; x < 7; x++)
{
    total +=  *totalS;
    *totalS++;

}




return total;  /// return the accumulator
}

ive stated some comments in the code to explain what does what and am not too sure why this code is not running the way it should. I have declared all variables as floats, i believe i have also addressed my pointers correctly and called them properly as well with the * and the &.

Answer 1

the following is not a complete answer, but just the corrections for a single function, with plenty of comments:

The original code:

float loadArray(float *weeklyS)   
{
    float sales;
    int x;

    for ( x = 0; x < 7; x++)
    {
        // have user enter the following
        printf("Enter sales for day %d: ",x  + 1);
        scanf("%d", weeklyS);
    }

    return sales;
}

the corrected code:

give the 'magic' number a meaningful name

#define DAYS_IN_WEEK 7

in 'main()', pass a pointer to the sales[] array.

loadArray( sales );

modify the prototype and the call in 'main()' to match this signature

void loadArray(float *sales)   
{
    // keep the scope of a variable to the minimum
    for ( int x = 0; x < DAYS_IN_WEEK; x++)
    {
        static char *day[] =
        {
            "Sunday",
            "Monday",
            "Tuesday",
            "Wednesday",
            "Thursday",
            "Friday",
            "Saturday"
        };

        // have user enter the daily sales
        printf( "Enter sales for %s: ", day[x] );

       // check for errors on calls to system functions
       // note: 'sales+i' advances to pointer 'sales' 
       //      by the length of each 'float' entry 
       //      times the value in 'i'
       // compare the returned value to '1' 
       //      because that is the number of format specifiers
       // use the format specifier '%f' because the input
       //      is to be converted to a 'float' value
       // input sales amount 
       if( 1 != scanf( "%f", sales+i ) )
       {  // then error occurred

           // output your error message 
           // and the system error text 
           // to 'stderr'
           // note: 'perror()' is found in 'stdio.h'
           perror( "scanf failed" ); 

           // note: 'exit()' and EXIT_FAILURE found in 'stdlib.h' 
           // unrecoverable error, exit the program
           exit( EXIT_FAILURE );
       } // end handling error
   } // end for each days' sales
} // end function: loadArray