How do I add an incrementing number to this For each batch script?

Question

In the below script, I am trying to set the contents of a text file to a friend number. The problem is that %numb% is not incrementing as I thought it would. Any idea how to do that? I tried researching however I do not know enough about For Each scripts to know what to do to have both an incrementing number and a for each in the script. Thanks!

@echo off
set numb=1
for /F "tokens=*" %%A in  (list.txt) do  (
   echo Doing junk with %%A and setting it as friend %numb%
   set Friend%numb%=%%A
    set /a numb=%numb%+1
)
set /a %numb%=%numb%-1   
echo there are %numb% Friends
pause

Stephan · Accepted Answer · 2017-11-06T18:49:12.143

1

You need delayed expansion.
I also changed your counter a bit and implemented another method of incrementing.

@echo off
setlocal enabledelayedexpansion
set numb=0
for /F "tokens=*" %%A in  (list.txt) do  (
   set /a numb+=1
   echo Doing junk with %%A and setting it as friend %numb%
   set Friend!numb!=%%A
)
echo there are %numb% Friends:
pause

edited Nov 06 '17 at 18:49

answered Nov 06 '17 at 17:45

Stephan

53,940
10
58
91

Aha perfect thank you @Stephan! Forgot that += was an option in batch! – Mark Deven Nov 06 '17 at 18:13
Should the counter get incremented before the echo and set inside the `FOR`? – Squashman Nov 06 '17 at 18:46
yeah, that seems a bit too modern for batch `;-)`. Thanks @Squashman: that was my intention - changed. – Stephan Nov 06 '17 at 18:48

How do I add an incrementing number to this For each batch script?

1 Answers1