PHP echo returning blank value

Question

So I am trying to link using data I got from a function but it keeps giving me a blank value for ID. Here's my code for what I'm trying to print

 <h3 style="text-align: center;">Seller: <?php $sellername = 
getNameFromListingID(); $id = getIDByUsername($sellername); echo "<a href=\"seller.php?id=\"".$id.">".$sellername."</a>";?></h3>

The functions work properly, I have tried printing both of them and it works. They're in a file called getinfo.php, which I have

Include 'getinfo.php';

At the top of my document.

The link with the name works but I always get seller.php?id=, with no value after. Any clue as to why?

I got it fixed, turns out the $id variable was in the wrong place. Thanks though. — Zach Zwerling, Nov 09 '17 at 14:00

score 2 · Accepted Answer · answered Nov 09 '17 at 13:56

2

You're ending the href attribute too early.

<a href=\"seller.php?id=".$id."\">

This will put the $id inside the href attribute, where it belongs.

answered Nov 09 '17 at 13:56

Josh

424
2
10

Thank you so much! I didn't know that you could put variables inside quotes, I thought you had to keep them in their own seperate section. I will vote yours as best answer as soon as I can. – Zach Zwerling Nov 09 '17 at 13:58
The varaiable's outside the quote (that's what the `".$id."` is doing). It's the escaped quote afterwards that's causing the problem. If we say $id=50, the end result before would look like ``. It's only the part inside the output quotes that forms your link. Moving the escaped quote so it sits at the end of the tag means it will include the $id value. – Josh Nov 09 '17 at 14:02

jaswrks · Answer 2 · 2017-11-09T14:09:38.593

Use single quotes in PHP, it's a good practice to get into, and it's also slightly (a teeny tiny bit) faster for PHP to process. Why? Because, when you use double quotes, you're telling PHP that your string contains variables that may need to be evaluated.

So in truth, you don't even need the quotes around variables here.

echo "<a href=\"seller.php?id=$id\">$sellername</a>";

But doing it like this would be following a best practice.
And now you don't need to escape \" double quotes that HTML uses.

echo '<a href="seller.php?id='.$id.'">'.$sellername.'</a>';

Caution: It's also a very good idea to escape special characters in anything you're outputting into HTML markup. That avoids the potential for an XSS vulnerability. See: htmlspecialchars()

echo '<a href="seller.php?id='.htmlspecialchars($id).'">'.htmlspecialchars($sellername).'</a>';

PHP echo returning blank value

2 Answers2