Only variables should be passed by reference in error

Question

I see there are lots of questions of the same topic. But none of them is helping me.

I am trying to fill up a form and sending the data into database. It is throwing an error as shown in the title.

public function insertQuestion($data){
    // print_r($data);
    // exit;
    $this->connect();
    $sth = $this->dbh->prepare('INSERT into tbl_questions(excel_id, class_id, subject_id, book_id, question_stem, option1, option2, option3, option4, option5, option6, option_img_1, option_img_2,option_img_3, option_img_4, option_img_5, option_img_6, correct_answer,image_name, marks, difficulty_level,outcome,created_on,question_type) 
    VALUES(?,?,?,?,?,?,?,?,?,?,? ,?,?,?,?,?,?,?,?,?,?,?,?,?) ');

    $sth->bindParam(1,  $data["excel_id"], PDO::PARAM_STR, 30);
    $sth->bindParam(2,  $data["class"], PDO::PARAM_INT);
    $sth->bindParam(3,  $data["subject_id"], PDO::PARAM_INT);
    $sth->bindParam(4,  $data["book_id"], PDO::PARAM_INT);
    $sth->bindParam(5,  isset($data["questiontitle"])?$data["questiontitle"]:"" , PDO::PARAM_STR, 500);
    $sth->bindParam(6,  isset($data["option1"])?$data["option1"]:"", PDO::PARAM_INT);
    $sth->bindParam(7,  isset($data["option2"])?$data["option2"]:"", PDO::PARAM_INT);
    $sth->bindParam(8,  isset($data["option3"])?$data["option3"]:"", PDO::PARAM_INT);
    $sth->bindParam(9,  isset($data["option4"])?$data["option4"]:"", PDO::PARAM_INT);
    $sth->bindParam(10, isset($data["option5"])?$data["option5"]:"", PDO::PARAM_INT);
    $sth->bindParam(11, isset($data["option6"])?$data["option6"]:"", PDO::PARAM_INT);
    $sth->bindParam(12, isset($data["optionimage1"])?$data["optionimage1"]:"", PDO::PARAM_INT);
    $sth->bindParam(13, isset($data["optionimage2"])?$data["optionimage2"]:"", PDO::PARAM_INT);
    $sth->bindParam(14, isset($data["optionimage3"])?$data["optionimage3"]:"", PDO::PARAM_INT);
    $sth->bindParam(15, isset($data["optionimage4"])?$data["optionimage4"]:"", PDO::PARAM_INT);
    $sth->bindParam(16, isset($data["optionimage5"])?$data["optionimage5"]:"", PDO::PARAM_INT);
    $sth->bindParam(17, isset($data["optionimage6"])?$data["optionimage6"]:"", PDO::PARAM_INT);
    $sth->bindParam(18, $data["answer"], PDO::PARAM_STR, 500);
    $sth->bindParam(19, isset($data["answerimage"])?$data["answerimage"]:"", PDO::PARAM_STR, 500);
    $sth->bindParam(20, $data["mark"], PDO::PARAM_INT);
    $sth->bindParam(21, $data["difficulty_level"], PDO::PARAM_INT);
    $sth->bindParam(22, $data["outcome"], PDO::PARAM_STR,200);
    $sth->bindParam(23, date('Y-m-d'), PDO::PARAM_STR,8);
    $sth->bindParam(24, $data["type"], PDO::PARAM_STR,20);


    if($sth->execute()) {
        $id = $this->dbh->lastInsertId(); 
        return $this->getQuestion($id);
    } else {
        return false;
    }

}

Please help, how do I rectifiy this error.

The line that has "question title", "option1" and "option2" are 36,37and 38 respectively — Santosh, Nov 10 '17 at 10:02
Assign whatever's in the value of the array to a variable before trying to bind. — Andrei, Nov 10 '17 at 10:04
You're trying to bind an *expression*, not a variable. You should use `bindValue` in that case, not `bindParam`. — deceze, Nov 10 '17 at 10:06
but `bindValue` accept only 3 parameter. How do I define the 4th parameter. — Santosh, Nov 10 '17 at 10:10
In most of your calls you don't need it. Where you do, you'll have to assign your expression to a variable and bind that variable. — deceze, Nov 10 '17 at 10:18
Thanks @deceze Your answer for `bindValue` is correct. Can you post it as answer so I can accept it as correct answer. — Santosh, Nov 10 '17 at 10:27

Only variables should be passed by reference in error

0 Answers0