Why does the application crash when I press the button to insert the values in the table?

Question

DataBaseHelper

    public class DataBaseHelper extends SQLiteOpenHelper {
    public static final String DATABASE_NAME ="Glucoplate.bd";
    public static final String TABLE_NAME ="User_table";

    public static final String COL_1 = "ID";
    public static final String COL_2 ="NAME";
    public static final String COL_3 = "SURNAME";
    public static final String COL_4 = "MARKS";


    public DataBaseHelper(Context context) {
        super(context, DATABASE_NAME, null, 1);
    }

    @Override
    public void onCreate(SQLiteDatabase db) {
    db.execSQL("CREATE TABLE" + TABLE_NAME + "(ID INTEGER PRIMARY KEY AUTOINCREMENT,NAME TEXT,SURNAME TEXT, MARKS INTEGER)");
    }

    @Override
    public void onUpgrade(SQLiteDatabase db, int oldVersion, int newVersion) {
        db.execSQL("DROP TABLE IF EXIST "+TABLE_NAME);
    }
    public boolean insertData(String name, String surname, String marks){
        SQLiteDatabase db = this.getWritableDatabase();
        ContentValues contentValues = new ContentValues();
        contentValues.put(COL_2,name);
        contentValues.put(COL_3,surname);
        contentValues.put(COL_4, marks);
        long result = db.insert(TABLE_NAME,null,contentValues);
        db.close();

        if (result == -1) {
            return false;
        }else{
         return true;
        }
    }
}

I followed the tutorial in Android Academy, but i doesn't want to work, even after, Building, and cleaning the project.

MainActivity

public class MainActivity extends AppCompatActivity {

    DataBaseHelper myDb;
    EditText txtName, txtSurname, txtMarks;
    Button btnClick;
    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);
    myDb= new DataBaseHelper(this);
        txtName = (EditText) findViewById(R.id.idName);
        txtSurname = (EditText) findViewById(R.id.idSurname);
        txtMarks =(EditText) findViewById(R.id.idMarks);
        btnClick = (Button) findViewById(R.id.idBtn);
        btnClick.setOnClickListener(new View.OnClickListener(){
            @Override
        public void onClick(View v){
            ClickMe();
        }
        });
    }

    private void ClickMe(){
        String name= txtName.getText().toString();
        String surname = txtSurname.getText().toString();
        String marks = txtMarks.getText().toString();
        Boolean result= myDb.insertData(name, surname, marks);
        if(result == true){
            Toast.makeText(this, "agragado", Toast.LENGTH_SHORT).show();
        }else{
            Toast.makeText(this,"Fallo",Toast.LENGTH_SHORT).show();
        }
    }
}

I'm using android Nougat, i tried another 4 methods and still doesn't work; Also the ID doesn't show any error, warning or anything it just crash.

it doesn't show any error it just said: "Unfortunately, Test has stopped. — Scalabrin, Nov 14 '17 at 07:16
@Scalabrin any crash leaves a stacktrace. That's how it's designed. If you catch the error that's an exception, but then there's nothing that can crash the app — Zoe, Nov 14 '17 at 07:17
please check your create table statement, whether the table is getting created or not. and post ur stack trace from the LogCat — Manoj kumar, Nov 14 '17 at 07:20

score 0 · Accepted Answer · answered Nov 14 '17 at 07:33

0

According to your code and stacktrace, you didn't add a space " " between the CREATE TABLE and TABLE_NAME. Add a " " after TABLE_NAME too.

answered Nov 14 '17 at 07:33

Royz

145
1
15

Why does the application crash when I press the button to insert the values in the table?

1 Answers1