Getting "Index was out of range. Must be non-negative and less than the size of the collection."

Question

I am trying to delete a row in a database through a grid view, however, I am receiving this error: "Index was out of range. Must be non-negative and less than the size of the collection."

 protected void ClientDataGrid_RowDeleting(object sender, GridViewDeleteEventArgs e)
 {
    String strConnString = ConfigurationManager.ConnectionStrings["PADSConnectionString"].ConnectionString;
    SqlConnection con = new SqlConnection(strConnString);    
    string client_code = ClientDataGrid.DataKeys[e.RowIndex].Values["client_code"].ToString();
    con.Open();
    SqlCommand cmd = new SqlCommand("delete from client where client_code=" + client_code, con);
    int result = cmd.ExecuteNonQuery();
    con.Close();
    if (result == 1)
    {
        ClientDataGrid.DataBind();
        Label1.Text = "Deleted successfully";
    }
}

protected void ClientDataGrid_RowDataBound(object sender, GridViewRowEventArgs e)
{       
    if (e.Row.RowType == DataControlRowType.DataRow)
    {
        string client_code = Convert.ToString(DataBinder.Eval(e.Row.DataItem, "client_code"));
        Button lnkbtnresult = (Button)e.Row.FindControl("ButtonDelete");
        if (lnkbtnresult != null)
        {
            lnkbtnresult.Attributes.Add("onclick", "javascript:return deleteConfirm('" + client_code + "')");
        }
    }

}

Specifically getting the error on this line

    string client_code = 
    ClientDataGrid.DataKeys[e.RowIndex].Values["client_code"].ToString();

What does the debugger give you for `e.RowIndex` and for the size of `ClientDataGrid.DataKeys.Count` ? — , Nov 14 '17 at 09:24
@AdolfBernardMoncawe: set a breakpoint in that line and use the debugger, you can inspect values for example in the quick watch window — Tim Schmelter, Nov 14 '17 at 09:26
Unrelated: You should be `using( SqlConnection ... )` and don't build your query through string concatenation. See for example https://stackoverflow.com/a/22782553/982149 — Fildor, Nov 14 '17 at 09:27
@AdolfBernardMoncawe And what about the size of `ClientDataGrid.DataKeys` (when debugging, hover your mouse on `DataKeys` then look for `Count`) ? — , Nov 14 '17 at 09:31
@AdolfBernardMoncawe: now compare that with `ClientDataGrid.DataKeys.Count`. I guess it is 0 which means it's empty and you cannot access the first item(index 0). Have you set the `DataKeyNames` property of the grid? — Tim Schmelter, Nov 14 '17 at 09:31
@BadMiscuit how do I check the the size of ClientDataGrid.DataKeys? — Adolf Bernard Moncawe, Nov 14 '17 at 09:32
@AdolfBernardMoncawe set what ? Pretty sure, as @TimSchmelter said, that you have an empty `DataGrid`. Make sure that you are doing a correct databinding — , Nov 14 '17 at 09:37
no its not empty, i am able to display the records on my datagrid — Adolf Bernard Moncawe, Nov 14 '17 at 09:43
I just solved it, I was using datakeys="client_code" instead of datakeynames="client_code". Thank you guys — Adolf Bernard Moncawe, Nov 14 '17 at 09:46

Getting "Index was out of range. Must be non-negative and less than the size of the collection."

0 Answers0