Regex matchs the whole string when I make a break

Asked Nov 15 '17 at 08:24

Active Nov 15 '17 at 08:24

Viewed 27 times

I have a problem with my regex, which should detect all echo functions in a string. So right now I have this expression:

/echo(.|\n)*?\(?"(.|\n)*"\)?;/g

This works until you make a break line in the quotes. If you do that, it would match the whole code until the end, as you can see in the picture:

You can get it here.

What did I wrong? What do I have to change?

asked Nov 15 '17 at 08:24

Julian Schmuckli

Never use `(.|\n)`, use `[\s\S]` if you are not sure DOTALL modifier can be used. – Wiktor Stribiżew Nov 15 '17 at 08:25
I now use the following regex to detect it. `/echo(.|\n)*?\(?"*"\)?;/g`. I just removed the dot and the `\n` between the brackets. – Julian Schmuckli Nov 16 '17 at 10:35
Replace `(.|\n)` with `[\s\S]` and you will have the same functionality at faster speed. You will also start matching a CR symbol. – Wiktor Stribiżew Nov 16 '17 at 12:08
@WiktorStribiżew But then it still does the same like `(.|\n)`. Or can you send me a full regex? – Julian Schmuckli Nov 16 '17 at 12:12
`(.|\n)*?` is a performance killer. NEVER, NEVER use it unless you are using ElasticSearch regex. – Wiktor Stribiżew Nov 16 '17 at 13:24

0 Answers0