Stop Thread Runnable impossible

Question

I have this thread:

myThread = new Thread(new Runnable() {
                    public void run() {

                        ServerSocket ss = null;

                        while (!end) {

                            final String incomingMsg;
                            try {
                                ss = new ServerSocket(2201);
                                ss.setSoTimeout(15000);
.. some code ...
    }
                });
                myThread.start();

Now i need to stop this with button but nothing work, and i have tried with some code like:

Handler handler= new Handler();
handler.removeCallbacks(myThread);
myThread.interrupt();

But Thread not stopping =(

Why don't you change the value of your 'end' variable? end = true; — diegoveloper, Nov 17 '17 at 16:29
Great idea, thank you, but I would also like to see if there are different methods. — J. Doe Cd, Nov 17 '17 at 16:31

score 1 · Answer 1 · answered Nov 17 '17 at 16:33

1

You can't. Android will automatically stops thread when needed.

What you can do is just stop executing the code inside run() method, Using boolean or something

answered Nov 17 '17 at 16:33

Paresh P.

6,677
1
14
26

1

This answer is not correct. Android does nothing to manage the threads you start, however you start them. See my answer for details. – Jeffrey Blattman Nov 17 '17 at 17:05

score 0 · Accepted Answer · answered Nov 17 '17 at 17:03

The accepted answer is not correct. Android does nothing to manage the threads you start, however you start them.

Technically speaking, threads cannot be "stopped". They can interrupted. Interrupting a thread just means that a flag is set, which you, in your thread's implementation, need to consider and exit from the run() method. For example,

  Thread t = new Thread(new Runnable() {
    @Override
    public void run() {
      while (!Thread.currentThread().isInterrupted()) {
        // Do stuff
      }
    }
  });

Then you can call t.interrupt() later on to "stop" your thread.

If you ignore the interrupted flag in your thread's implementation, your thread will never stop. For example, if you replaced // Do stuff above with SystemClock.sleep(Integer.MAX_VALUE) the thread will never exit, regardless of it being interrupted.

Many IO operations implemented in the SDK also pay attention to the interrupted flag, which is why you can interrupt a thread that's participating in blocking IO. See InterruptedException.

score 0 · Answer 3 · answered Nov 17 '17 at 17:07

0

You can use .stop(), but it is very bad practice and it can cause you some troubles. Try to add some boolean inside your .run() (like Wizard said)

answered Nov 17 '17 at 17:07

Aleksandar Mironov

564
3
8

.stop is deprecated =) https://stackoverflow.com/questions/16504140/thread-stop-deprecated – J. Doe Cd Nov 17 '17 at 17:12
My bad. I haven't used .stop() quite a lot of time. Good luck finding working solution. – Aleksandar Mironov Nov 17 '17 at 17:17

Stop Thread Runnable impossible

3 Answers3