Text modification in Java Netbeans

Question

I'm trying to modify text in a file but instead of modifying it, it is just adding a new line with the new information:

Here's my code

  String id= IDSearch.getText();
        String newname = NameText.getText();
        String newbarcode = BarcodeText.getText();
        String newsupplier= SupplierText.getText();
        String newamount1= AmountText.getText();


        ArrayList<Item> ItemsList = new ArrayList<>();

        if (id.isEmpty() || newname.isEmpty() || newbarcode.isEmpty() || newsupplier.isEmpty() || newamount1.isEmpty()) {
            JOptionPane.showMessageDialog(this, " Please Fill all fields");}
        else{
        try {
            File Items = new File ("Items.txt");
            FileReader fr = new FileReader(Items);
            BufferedReader br = new BufferedReader(fr);
            String data;
            Item tempItem;

            while ((data = br.readLine()) != null) {
                        tempItem = new Item(data);
                        if (tempItem.getID().equals(IDSearch)) 
                        {
                            tempItem.setItemName(newname);
                            tempItem.setItemBarcode(newbarcode);
                            tempItem.setSupplierID(newsupplier);
                            tempItem.setAmount(newamount1);  

                        }
                        ItemsList.add(tempItem);
                    }
            try (PrintWriter pw = new PrintWriter(new FileWriter(Items, true))) {

                    ItemsList.forEach((item) -> {
                        pw.println(newname + ";" + newbarcode+ ";" + newsupplier + ";" + newamount1);


                    });
                    JOptionPane.showMessageDialog(this, "Student Updated Succesfully");

                } 
                }catch (IOException ex) {


        }
        }
    }

I can't seem to be able to update the tex file the way it was supposed to update. Any help would be much appreciated!

In a finally statement of the writing code. I never seen a try() like this in java, but this would be done when this statement is completed — dirceusemighini, Nov 23 '17 at 20:56
@dirceusemighini when you use a try with resources block in java, any resource declared at the begining will close automatically at the end of the block. This works for anything that implements `autoCloseable`. — Touniouk, Nov 23 '17 at 21:10
Nice @Touniouk I'd never seen this block, this is new for me. — dirceusemighini, Nov 23 '17 at 21:13
@Neal Hampson, replace `pw.println([...]);` with `pw.write([...])`. — Touniouk, Nov 23 '17 at 21:22
@Touniouk It's still adding it to the next line and not replacing it — Neal Hampson, Nov 23 '17 at 21:28
Possible duplicate of [Java Replace Line In Text File](https://stackoverflow.com/questions/20039980/java-replace-line-in-text-file) — Touniouk, Nov 24 '17 at 09:16

score 0 · Answer 1 · answered Nov 23 '17 at 21:34

0

You have append set to true. Doing new FileWriter(Items, false) or just (new FileWriter(Items) should fix the issue.

answered Nov 23 '17 at 21:34

Touniouk

375
1
13

Now it's either replacing all the text in the file or deleting all and leaving only one line. How do I fix that? – Neal Hampson Nov 23 '17 at 21:54
HELP ITS REPLACING ALL THE TEXT! – Neal Hampson Nov 23 '17 at 22:05
What are you trying to do? – Touniouk Nov 23 '17 at 23:25
I'm trying to replace only one line in the text file and not the whole text – Neal Hampson Nov 24 '17 at 07:56

Text modification in Java Netbeans

1 Answers1