0

In trying the next PHP 7.2 release out on my site (previously we've been on 7.1 with no problems) I noticed that one of our older scripts suddenly began throwing up this warning.

Warning: Use of undefined constant priority - assumed 'priority' (this will throw an Error in a future version of PHP) in /../plugins.inc.php on line 146

Of course I could hide this as it's only a warning but I'd rather figure out the problem than store them up for PHP8.0. The code it relates to is this block and nothing else in the file appears to be related to it.

function SortByActionPriority($a, $b) {
    return $a[priority] > $b[priority] ? 1 : -1;
}

Sadly this is not a system I'm familiar with (it's an older one) and it has thousands of PHP files, so I'm not entirely sure where else in the program this is being used for full context.

MarkJ99
  • 11
  • 1
  • 3
  • 1
    it needs to be "priority" obviously. 7.2 promoted this from notice to warning – Gordon Dec 02 '17 at 08:09
  • 1
    Read about why [`$a[priority]`](http://php.net/manual/en/language.types.array.php#language.types.array.foo-bar) is not correct PHP (unless the `priority` [constant](http://php.net/manual/en/language.constants.php) is [defined](http://php.net/manual/en/function.define.php)). – axiac Dec 02 '17 at 08:17
  • if your trying to find them use something like `notepad++` that lets you look though files with a regular expression, then put this in as the search for `\$\w\s*\[\s*[^\]]+\s*\]` – ArtisticPhoenix Dec 02 '17 at 08:26
  • "Of course I could hide this as it's only a warning…" - That's precisely what your previous versions `php.ini` did; not related to php 7.2 itself. – mario Dec 02 '17 at 08:53

0 Answers0