Two inserts, two tables, one PDO transaction, double SQL result

Question

EDIT I dont believe this is a duplucatie question of that mysqli question, and do believe it deserves to be a question on its own.

So I'm trying to get some data from a form into the correct tables, using PDO Transactions (this is new to me).

The SQL inserts correctly into the tables, but double. So I end up with a double result in each table.

I read about there being an issue with the page refreshing twice because of the favicon, or this being a browser issue. But even after a restart of the server and multiple browsers tested, I think it's just my code.

try {
    //$mysqli->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION);
    $mysqli->begin_transaction();

    $stmt = $mysqli->prepare("INSERT $table1 (status, customer, product, ord_num, return_code, dop, sn, problem_descr, repair_descr, comments) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?)");
    $stmt->bind_param("ssssssssss", $status, $customer, $product, $ord_num, $return_code, $dop, $sn, $problem_descr, $repair_descr, $comments);
    $stmt->execute();
    if (!$stmt->execute()) {
        echo "Execute failed: (" . $stmt->errno . ") " . $stmt->error;
    }
    $stmt->close();

    $stmt = $mysqli->prepare("INSERT $table2 (part1, part2, part3, part4, part5, part6, part7, part8, part9, part10, part11, part12, part13, part14, part15, part16, part17, part18, part19, part20) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)");
    $stmt->bind_param("ssssssssssssssssssss", $part1, $part2, $part3, $part4, $part5, $part6, $part7, $part8, $part9, $part10, $part11, $part12, $part13, $part14, $part15, $part16, $part17, $part18, $part19, $part20);
    $stmt->execute();
    if (!$stmt->execute()) {
        echo "Execute failed: (" . $stmt->errno . ") " . $stmt->error;
    }
    $stmt->close();

    $mysqli->commit();
} catch(PDOException $ex) {
    //Something went wrong, rolback!
    $mysqli->rollBack();
    echo $ex-getMessage();
}

Are you trying to catch PDOException when you are using the mysqli ext ? — frz3993, Dec 09 '17 at 02:58
typo in your exception which will cause issues if ever hit, which wont happen ^, `echo $ex-getMessage();` — Lawrence Cherone, Dec 09 '17 at 03:04

score 2 · Accepted Answer · answered Dec 09 '17 at 02:54

2

This needs to change:

$stmt->execute();
        if (!$stmt->execute()) {

just

if (!$stmt->execute()) {

is enough.

Once you run $stmt->execute(); ones and then again put it inside the if statement to see if it returns true, you endup executing the statement twice. For which you are seeing the double entries.

answered Dec 09 '17 at 02:54

Kamrul Khan

3,260
4
32
59

Thank you, this did the trick. – Robin GM Dec 09 '17 at 14:54
you are welcome! – Kamrul Khan Dec 09 '17 at 16:59

score 0 · Answer 2 · answered Dec 09 '17 at 03:01

0

or you can do like this

$run = $stmt->execute();
if (!$run) {

We Just need to run the execute statement once.

answered Dec 09 '17 at 03:01

Abdulla Nilam

36,589
17
64
85

Two inserts, two tables, one PDO transaction, double SQL result

2 Answers2