0

I am trying to send file from client side to server side. Here, WritableGUI is an interface which display the file name in a text area. File transferred to server but gets corrupted. Sometimes transferred file size is right but sometimes it shows file size 0 kb. whats wrong with my code?

Client Side:

public class FileClient {

    private Socket s;
    private String fileName;
    private long fileLength;

    public FileClient(String host, int port, String file, String fileName, long FileLength) {
        this.fileName = fileName;
        this.fileLength = FileLength;
        try {
            s = new Socket(host, port);
            sendFile(file);
        } catch (Exception e) {
            e.printStackTrace();
        }
    }

    public void sendFile(String file) throws IOException {
        DataOutputStream dos = new DataOutputStream(s.getOutputStream());
        FileInputStream fis = new FileInputStream(file);
        byte[] buffer = new byte[1024];
        dos.writeUTF(fileName);
        dos.writeLong(fileLength);
        while (fis.read(buffer) > 0) {
            dos.write(buffer);
        }
        fis.close();
        dos.close();
    }
}       

Server Side:

public class FileServer extends Thread {

    ServerSocket server;
    int port = 8877;
    WritableGUI gui;

    public FileServer(WritableGUI gui, int SOCKET_PORT) throws IOException {
        this.port = SOCKET_PORT;
        this.gui = gui;

        try {
            server = new ServerSocket(port);
        } catch (IOException ex) {
            Logger.getLogger(MessageListener.class.getName()).log(Level.SEVERE, null, ex);
        }
    }

    public void run() {
        while (true) {
            try {
                Socket clientSock = server.accept();
                saveFile(clientSock);
            } catch (IOException e) {
                e.printStackTrace();
            }
        }
    }

    private void saveFile(Socket clientSock) throws IOException {
        DataInputStream dis = new DataInputStream(clientSock.getInputStream());
        FileOutputStream fos = new FileOutputStream(dis.readUTF());
        byte[] buffer = new byte[1024];

        gui.write("File Received: " + dis.readUTF());

        long filesize = dis.readLong(); // read file size in separate msg
        int read = 0;
        int totalRead = 0;
        int remaining = (int) filesize;
        while ((read = dis.read(buffer, 0, Math.min(buffer.length, remaining))) >= 0) {
            totalRead += read;
            remaining -= read;
            System.out.println("read " + totalRead + " bytes.");
            fos.write(buffer, 0, read);
        }
        dis.close();
        fos.close();
    }
}
gre_gor
  • 6,669
  • 9
  • 47
  • 52

1 Answers1

0
while (fis.read(buffer) > 0) {
        dos.write(buffer);
    }

As usual. Wrong copy-loop. Try this:

int count;
while ((count = fis.read(buffer)) > 0) {
        dos.write(buffer, 0, count);
    }

and have a good think about why.

user207421
  • 305,947
  • 44
  • 307
  • 483