C# Ctrl+F doesn't work sometimes

Question

I have a winforms application where in I have a textbox inside a form. I need to set focus to the textbox whenever I press 'Ctrl+F'. I have the following code in keyup event.

        private void frm_KeyUp(object sender, KeyEventArgs e)
        {     
            // Handle 'Ctrl + F' to Find    
            if (e.KeyData == (Keys.Control | Keys.F))
                SetFocus();
        }

Problem I have here is that sometimes, even though the focus is on form and I try 'Ctrl+F' the condition doesn't run. I know, as soon as I press 'Ctrl' the event gets fired even before I would have pressed key 'F'. Eventually it works, when I press both the keys at the very same time. So to the user it might look like the screen is unresponsive to the keys sometimes.

How can I overcome this situation?

Why not handle KeyDown and check there if Control is down when F is pressed? — Sami Kuhmonen, Dec 13 '17 at 12:49

score 3 · Accepted Answer · answered Dec 13 '17 at 12:49

You're using the KeyUp event and checking if the event contains both keys. This will only happen when you release both keys at the same time.

Change it to the KeyDown event instead, and check whether Ctrl was pressed at the moment F was pressed:

if (e.Control && e.KeyCode == Keys.F)
{
    // ...
}

C# Ctrl+F doesn't work sometimes

1 Answers1