Variables in response is undefined?

Question

So I have an issue that keeps bugging the hell our of me I was hoping that someone could help me "level up" a bit. I have this function in a service:

this.getChatStreams = function(callback) {
    $http.get(envService.read('apiUrl') + '/messaging/chat')
      .then(function(response) {
        callback(response);
      }).catch(function(response) {
        callback(response);
      });
  };

Now that works, yes I'm aware I can do some nicer error handling. However in my call back:

chatService.getChatStreams(function(response) {
  $scope.emptychat = true;
  if (response.data.conv !== null) {
    $scope.emptychat = false;
    $scope.chats = response.data.conv;
    startChat();
  }
});

I get an error in the console:

undefined is not an object (evaluating response.data.conv)

response.data.conv however is null, but not undefined - so what am I doing wrong?

/Peter

You should use promises instead of callbacks. – SLaks Dec 15 '17 at 14:44 — SLaks, Dec 15 '17 at 14:44

score 0 · Answer 1 · answered Dec 15 '17 at 14:49

0

Try this !

var response= $.parseJSON(response);

and access

answered Dec 15 '17 at 14:49

Rafael Castelani

100
6

David Anthony Acosta · Answer 2 · 2017-12-15T15:19:58.037

0

Why not just run:

  if (response.data.conv) {

That way you check both null and undefined, rather than just if null?

edited Dec 15 '17 at 15:19

answered Dec 15 '17 at 15:06

David Anthony Acosta

4,766
1
19
19

There is no reason to write `response.data.conv && response.data.conv !== null` – SLaks Dec 15 '17 at 15:16

Variables in response is undefined?

2 Answers2