writing array of structures to bin file

Asked Dec 17 '17 at 04:27

Active Dec 17 '17 at 04:43

Viewed 139 times

Hello I have an array of structures that I am trying to write to a bin file. However I can only get the 'name' data to show. correctly.the rest comes out as illegible garbage .

 struct employee
    {
       char name[15];
        float sal, rate, raise, newsal;
    }e;

Here is my savebin function to save to the bin file.

void savebin(struct employee e[], int n)
    {
        FILE *f;
       f=fopen("c:\\cfiles\\employee2.text", "wb");
        fwrite(&e, sizeof(struct employee),n,f);
        fclose(f);
    }

edited Dec 17 '17 at 04:28

user2736738

30,591
5
42
56

asked Dec 17 '17 at 04:27

user2998459

`&e` => `e`, otherwise you're writing the *pointer* only. – Antti Haapala -- Слава Україні Dec 17 '17 at 04:28
This code seems fine. What output do you expect to get? – Jacob H Dec 17 '17 at 04:33
1

@JacobH of course it is not fine. It is full of undefined behaviour, unless `sizeof` pointer happens to be greater and or equal to `sizeof(struct employee)`. – Antti Haapala -- Слава Україні Dec 17 '17 at 04:34
Its not printing the rest of the structure values. It only prints name and the rest is gibberish . – user2998459 Dec 17 '17 at 04:37
@user2998459 also, you're writing a *binary* file, the rest of it is supposed to be gibberish. But in addition to that your `savebin` doesn't even store the data correctly. Notice that `struct employee e[]` does not declare an array but a pointer, i.e. `struct employee *e`. If you want a better answer you need to provide a proper [mcve]. And please indent your code properly. – Antti Haapala -- Слава Україні Dec 17 '17 at 04:42

writing array of structures to bin file

0 Answers0