Double If Statement for Batch

Question

I'm relatively new to StackOverflow, so I apologize for any mistakes I might make. I'm making a Fallout-type skill system in a Batch script, and the idea is that you have a certain amount of skill points to assign, and if that number reaches 0 then you can no longer assign skill points. This is the part that isn't working for me:

if "%sdec%"=="5" (
if "skp"=="0" goto skperrors
set /a "skp=skp-5"
set /a "s=s+5"
)

sdec is the number that the person inputs for how many skill points they would like to assign. The "if skp=0" segment is only assigned for positive integers, as 0 would skip that skill and any negatives would subtract thus giving them more skill points to spend. In my head, it checks to see what number they input, and then checks to see if they have 0 skill points. If they do, then it redirects them to an error message. If not, it just goes past it. But when I run the code, it seems to skip right over it. Much love for anyone who can help <3

if "%skp%"=="0", doesn't that work better? – Dominique Jan 04 '18 at 14:23 — Dominique, Jan 04 '18 at 14:23

score 1 · Accepted Answer · answered Jan 04 '18 at 14:27

1

Use this code:

if "%sdec%" == "5" (
    if "%skp%" == "0" goto skperrors
    set /A skp-=5
    set /A s+=5
)

You missed the percent signs around name of environment variable skp and so the string "skp" was compared with "0" which of course is never equal. The double quotes are also compared. See answer on Symbol equivalent to NEQ, LSS, GTR, etc. in Windows batch files for details on comparing strings or integers with command IF in a batch file.

answered Jan 04 '18 at 14:27

Mofi

46,139
17
80
143

Weeeooowwwwww. Can't believe I didn't catch the missing percent signs. Thanks. – Gl1tch Crashed Jan 05 '18 at 13:36

Double If Statement for Batch

1 Answers1