How to remove comma in while loop?

Question

I am using a while loop that is as follows:

<?php while(has_sub_field('available_locations')): ?>

    <a href="<?php the_sub_field('location_url'); ?>"><?php the_sub_field('locations'); ?></a>,

<?php endwhile; ?>

The problem is that Last Location has also comma with it. For example:

California, Texas,

But I would like to look it like this:

California, Texas

Since this is containing both HTML and PHP codes, should I store in a variable and use rtrim to cut the last comma, or there is something better solution for it. If I put this in variable, personally I think this is not good solution. Please do respond.

Update: The question is not about only removing last character rather it contains an anchor tag which if I store in a variable, then it is not creating hypertext.Like

Google

But after storing it in variable, the result is like this:

https://www.google.co.in Google

Ultimatly you either need to know when you're at the end, or assign your results to an array so you can work with a finite set of values. — Scuzzy, Jan 16 '18 at 07:44
I think this is not a duplicate question. The question is not about only removing last character rather it contains an anchor tag which if I store in a variable, the it is not creating hypertext. — Umar, Jan 16 '18 at 08:34
Show the HTML source code of the "https://www.google.co.in Google". — ino, Jan 16 '18 at 08:50
Offert dans la ou les régions suivantes : http://ctfrandev.com/fr/promotions/?regions=491Québec — Umar, Jan 16 '18 at 09:25
You can be certain that this question is a duplicate on SO. I'm at the cricket so I can't help to search. Start with variable as empty string. Echo it. After first iteration overwrite variable as comma. Such simple tasks are duplicates on SO. — mickmackusa, Jan 16 '18 at 10:12
https://stackoverflow.com/questions/8312374/echo-a-comma-on-all-but-the-last-value-result-from-mysql-fetch-array @lawrence please close. — mickmackusa, Jan 16 '18 at 10:16
https://stackoverflow.com/questions/4705814/stripping-last-comma-from-a-foreach-loop — mickmackusa, Jan 16 '18 at 12:23

ino · Answer 1 · 2018-01-16T09:48:24.863

3

Use PHP substr() function.

Example:

`substr("abcdef", 0, -1);  // returns "abcde"`

So in your case collect all output HTML code to the variable $links and then cut off the last character using substr and print it with echo:

<?php 
$links = '';
while(has_sub_field('available_locations')){ 
   $links .= '<a href="'. the_sub_field('location_url') .'">'.  the_sub_field('locations') .'</a>,';
}
echo substr($links, 0, -1);
?>

Or use build an array and use implode()

<?php 
$links = [];
while (has_sub_field('available_locations')) { 
   $links[] = '<a href="'. the_sub_field('location_url') .'">'.the_sub_field('locations').'</a>';
}
echo implode(', ', $links);
?>

EDIT
Apparently the function used to generate the URL sends its output directly to the browser which cause broken HTML links.
To avoid such situation use PHP Output Control Functions that catch the output and enable the data/string manipulations.

<?php
ob_start(); // Turn on output buffering
while(has_sub_field('available_locations')){
  '<a href="'. the_sub_field('location_url') .'">'.  the_sub_field('locations') .'</a>,';
}
$links = ob_get_contents(); // Get the contents of the output buffer
ob_end_clean(); // Clean (erase) the output buffer and turn off output buffering

echo substr($links, 0, -1); // removal of the last character, the comma.
?>

edited Jan 16 '18 at 09:48

answered Jan 16 '18 at 07:47

ino

2,345
1
15
27

1

@Scuzzy beat my edit, oh well +1 – Lawrence Cherone Jan 16 '18 at 07:53
1

@LawrenceCherone Thanks for update! Good to see different approaches with same results. – ino Jan 16 '18 at 08:01
Ya could even do it with ob_start() ob_end_clean() if ya mad. ;p – Lawrence Cherone Jan 16 '18 at 08:02
@LawrenceCherone No guys, it's not workings. It basically removes the comma, but it's directly showing the url. Anchor tag is not working. – Umar Jan 16 '18 at 08:12
And how the code behave before? What was the output of your original code? – ino Jan 16 '18 at 08:27
The anchor tag is used to create a hyper text, but after using your code, the url and Name are seperated. It is not creating hypertext. – Umar Jan 16 '18 at 08:30
I do not see any syntax error to break the output html code of the anchor. What is the exact output of one anchor? – ino Jan 16 '18 at 08:44
1

@ino See my update on the question. – Umar Jan 16 '18 at 08:47
@Umar I have added the output buffering to the solution as suggested LawrenceCherone. Let me know if it works. – ino Jan 16 '18 at 09:49

score 2 · Answer 2 · answered Jan 16 '18 at 07:52

2

One option is to collect all your strings in an array, and use implode to join them.

<?php

$links = array();
while( has_sub_field( 'available_locations' ) )
{
  $links[] = '<a href="'.the_sub_field('location_url').'">'.the_sub_field('locations').'</a>';
}
echo implode( ', ', $links );

answered Jan 16 '18 at 07:52

Scuzzy

12,186
1
46
46

It will directly show the url. So, it.s not working. – Umar Jan 16 '18 at 08:05
Ah crazy wordpress, ok this answer is junk then, – Scuzzy Jan 16 '18 at 21:33

Aiyaz Khorajia · Answer 3 · 2018-01-16T07:57:53.440

1

I think you are using ACF plugin, to trim the last comma, you can use rtrim() function with get_sub_field() of ACF or merge all links like bellow.

<?php
    $links = array();
    while( has_sub_field( 'available_locations' ) )
    {
      $links[] = '<a href="'.get_sub_field('location_url').'">'.get_sub_field('locations').'</a>';
    }
    echo implode( ', ', $links );
?>

edited Jan 16 '18 at 07:57

answered Jan 16 '18 at 07:44

Aiyaz Khorajia

598
2
11

How to remove comma in while loop?

3 Answers3