i cant find geometric average in c

Question

#include <stdio.h>
#include <locale.h>
#include <conio.h>
#include <string.h>
#include <math.h>

int main()
{

 int array[5];
 int x;
 int max;
 int y;
 float k;

 printf("Enter capacity of array")
 scanf("%d",&y);

 for(x=0;x<y;x++)
    {
     printf("Enter the numbers:");  
     scanf("%d",&array[x]);
     max*=array[x]; 
    }

  k=pow(max,(1/y) );

  printf("%d\n",max); 
  printf(" %f",k);

 getch();
 }

Hello everyone, I want find geometric average but I always get k=1 I know it's simple code but I can't see the problem, can anyone help me?

In `max*=array[x];` the variable `max` was *uninitialised* so the result will be indeterminate. It should be `int max = 1;` apart from any algorithm problem. — Weather Vane, Jan 26 '18 at 21:17
Possible duplicate of [Division result is always zero](https://stackoverflow.com/questions/2345902/division-result-is-always-zero) — phuclv, Jan 27 '18 at 02:29

score 1 · Answer 1 · answered Jan 26 '18 at 21:13

1

With int y, the expression 1/y is equal to 0 in most cases...

More precisely, in all cases, except for when y is -1 or 0 or +1.

So you might want to start by changing it to 1.0/y...

answered Jan 26 '18 at 21:13

goodvibration

5,980
4
28
61

1

P.S.: the variable `max` is not even initialized in your code, so I guess you've got a whole bunch of other problems there... – goodvibration Jan 26 '18 at 21:18

score -1 · Answer 2 · answered Jan 26 '18 at 22:01

-1

check this out.

#include <stdio.h>
#include <math.h>
int main()
{
    double array[5];
    int max = 1, y;
    printf("Enter Capacity of Array:\n");
    scanf("%d", &y);
    for (int i = 0;i < y;i++)
    {
        printf("Enter the %d Number:\n",i+1);
        scanf("%lf", &array[i]);
        max *= array[i];
    }
    printf("Multiplication Of Array = %d\n\n", max);
    printf("Geomteric Mean = %0.2lf\n", pow(max, (1.0/y)));
    getch();
}

answered Jan 26 '18 at 22:01

Rajesh Dubey

9
7

2

That array[5] is going to be a big problem.... – Max Jan 26 '18 at 22:20
how? can you explain it – Rajesh Dubey Jan 27 '18 at 13:39
1

What if they want to enter 6 items? You've overflowed the array. – Max Jan 27 '18 at 18:25
i just have given example how he can do it..that's all.He is doing programming then he should know if he will enter more than 5 numbers it will show garbage output. – Rajesh Dubey Jan 27 '18 at 20:49

score -1 · Answer 3 · answered Jan 27 '18 at 09:31

#include <stdio.h>
#include <conio.h>
#include <math.h>

int main()
{
int x;
int max = 1;
int y;
float k;

printf("Enter capacity of array");
scanf("%d",&y);
int array[y];

for(x=0;x<y;x++)
    {
    printf("Enter the %d number:",x+1);  
    scanf("%d",&array[x]);
    max*=array[x]; 
    }

k=pow(max,(1.0/y) );

printf("%d\n",max); 
printf("%f",k);
getch();

}

Hope this will help

i cant find geometric average in c

3 Answers3