stop music playing in a thread

Question

I am trying to make multiple audio files playing simultaneously, so I decide to use thread to trigger them (otherwise the one can only start playing until the previous finished).

This is how I do it.

sounds is a list of SoundPlayers

for (int i = 0; i < sometimes; i++)
{
    SoundPlayer sp = sounds[i];
    Thread thread = new Thread(() =>
    {
        sp.PlayLooping();
    });
    threads.Add(thread);
 }
 foreach (Thread thread in threads)
 {
     thread.Start();
 }

Then I use a timer to stop all the audio file after 1 second.

foreach(Thread t in threads)
{
    kill_thread(t);
    MessageBox.Show(t.IsAlive.ToString());
}
[SecurityPermissionAttribute(SecurityAction.Demand, ControlThread = true)]
private void kill_thread(Thread t)
{
   t.Abort();
}

I get kill_thread method from here. With the message pops up from messagebox, the target thread has already been killed in this way. However, the music is keep playing.

Is there any way to stop the music? Thanks in advance!

@BWA I thought about that. But I am quite interested in why the audio file is still playing after it's thread has been killed. — Jieke Wei, Feb 07 '18 at 13:53
*...Plays and loops the .wav file using a new thread, and loads the .wav file first if it has not been loaded...* https://msdn.microsoft.com/en-us/library/system.media.soundplayer.playlooping(v=vs.110).aspx — Michael, Feb 07 '18 at 13:57
Just want to say that [you should almost NEVER use `Thread.Abort()`](https://stackoverflow.com/a/1560567/106159). I'm not usually one for dogma, but `Thread.Abort()` is evil. — Matthew Watson, Feb 07 '18 at 14:07
The accepted answer is wrong. "The .wav will be played until the Stop method is called." - MSDN. https://msdn.microsoft.com/en-US/library/system.media.soundplayer.playlooping(v=vs.110).aspx No reason to kill any threads — , Feb 07 '18 at 14:12

score 1 · Accepted Answer · edited Jun 20 '20 at 09:12

1

You shouldn't be killing any thread, yours or otherwise. In fact, you shouldn't even be creating threads. As the others have said, if you must end a thread, end it gracefully, don't nuke it via Abort. It can leave your process in an unknown state.

Just call:

soundPlayer.Stop();

MSDN:

SoundPlayer.PlayLooping Method

The .wav will be played until the Stop method is called. https://msdn.microsoft.com/en-US/library/system.media.soundplayer.playlooping(v=vs.110).aspx

As for concurrent playback, SoundPlayer isn't designed for elaborate concurrent playback (in fact it won't even do it). You need to use a different media API for that.

read my description of the question. Creating the thread is to play multiple music simultaneously, not about "playing a music" – Jieke Wei Feb 07 '18 at 14:22
@JiekeWei Also your title explicitly says _"**stop** music playing in a thread"_ and your body _"Is there any way to **stop** the music?"_ which I have covered, not _"play multiple music simultaneously"_. `SoundPlayer` isn't designed for elaborate concurrent playback. You need to use a different media API for that. Feel free to ask a _new question_ – Feb 07 '18 at 14:39
Yeah, I found that problem. I cannot hear the audio files playing in the same time, only the last one. I will consider about a new api – Jieke Wei Feb 07 '18 at 14:44

score 0 · Answer 2 · answered Feb 07 '18 at 14:00

0

This is because the PlayLooping() method starts a new thread itself, so killing your thread does not stop the player thread.

https://msdn.microsoft.com/it-it/library/system.media.soundplayer.playlooping(v=vs.110).aspx

answered Feb 07 '18 at 14:00

Federico Terraneo

11
6

stop music playing in a thread

2 Answers2

See also