Foreach with Promise not waiting on method results

Question

I am trying to iterate through the JSON files generated by the protractor tests. I pull all the file names into an array and call a method that opens and parses through the each file, post the results to the database and pass back a passed/failed flag.

I have tried all the examples here Make angular.forEach wait for promise after going to next object and still get the same results.

The method is actually called, but the results are not posted to the db. I have tested the parser.parseResults on an individual file and it successfully posted to the db, so it has to have something to do with the promise not resolving correctly.

Is it not possible to do something like this in the jasmine/protractor framework? Or do I have something wrong in the code?

I have included the code for my latest attempt. Thank You Christine

matches.reduce(function (p, val) {
    console.log('val', val);
    return p.then(function () {
          return parser.parseResults(val);
     });
   }, Promise.resolve()).then(function (finalResult) {
       console.log('finalResult = ', finalResult);
   }, function (err) {
       console.log('error in reduce',err);
   });

parser.parseResults code

protractorParser.prototype.parseResults = function (fileName) {
    return new Promise((resolve, reject) => {

        console.log('In parseresults', fileName);
        json.readFile(fileName, function (err, obj) {
            try {

                if (err != null) {
                    console.log('error reading file',err);
                    reject(err);
                }
                console.log('obj - ',obj);
                var results = [];

                var Passed = 0;
                var Message = '';
                var Stack = '';
                for (var suite in obj) {
                    var specs = obj[suite].specs;
                    console.log('spec - ', specs);
                    if (specs.length > 0) {
                        for (var i = 0; i < specs.length; i++) {
                            var assert = specs[i];
                            var tcR = new RegExp(/TC[\d]+/);
                            var tc = assert.description.match(tcR);

                            if (!assert.failedExpectations.length) {
                                Passed = 1;
                            }
                            else {
                                assert.failedExpectations.forEach((expectation) => {
                                    Message = expectation.message;
                                    Stack = expectation.stack.split('\n')[1].trim();
                                })
                                Passed = 0;
                            }
                            if (tc != null) {
                                utility.TestDataManager.insertAutomationResults(tc[0], assert.description, Passed, process.env.testBuild,
                                    'P', Message, Stack, 0, moment().utcOffset(config.get('settings.timeOffset')).format('YYYY-MM-DDTHH:mm:ss'), '')
                                    .then(function (resp) {
                                        resolve(Passed);

                                    }, (err) => {
                                        console.log('Posting to Database failed ', err);
                                        reject(err);
                                    });
                            } else {
                                console.log('no test case found for test: ' + assert.description + ' -- skipping');
                                reject(err); 
                            }
                        }
                    }
                }
            }
            catch (err) {
                console.log('rejecting opening file');
                reject(err);
            }
        });
    })
}

Answer 1

If there is not exactly one suite in the obj, with exactly one spec, then your promise is either resolved not at all or multiple times.

Avoid wrapping too many things in the new Promise constructor - always promisify on the smallest possible level, and use promise chaining afterwards.

protractorParser.prototype.parseResults = function (fileName) {
    return new Promise((resolve, reject) => {
        console.log('In parseresults', fileName);
        json.readFile(fileName, function (err, obj) {
            if (err != null) {
                console.log('error reading file', err);
                reject(err);
            } else {
                resolve(obj);
            }
        });
    }).then(function(obj) {
        console.log('obj - ',obj);
        var results = [];

        for (var suite in obj) {
            var specs = obj[suite].specs;
            console.log('spec - ', specs);
            for (let i = 0; i < specs.length; i++) {
                const assert = specs[i];
                const tcR = /TC[\d]+/;
                const tc = assert.description.match(tcR);

                let Passed = 1;
                let Message = '';
                let Stack = '';
                if (assert.failedExpectations.length) {
                    const expectation = assert.failedExpectations[assert.failedExpectations.length-1];
                    Passed = 0;
                    Message = expectation.message;
                    Stack = expectation.stack.split('\n')[1].trim();
                }
                if (tc != null) {
                    const time = moment().utcOffset(config.get('settings.timeOffset')).format('YYYY-MM-DDTHH:mm:ss');
                    const promise = utility.TestDataManager.insertAutomationResults(tc[0], assert.description, Passed, process.env.testBuild, 'P', Message, Stack, 0, time, '');
                    results.push(promise.catch(err => {
                        console.log('Posting to Database failed ', err);
                        throw err;
                    }));
                } else {
                    console.log('no test case found for test: ' + assert.description + ' -- skipping');
                    // I don't think you want to `throw err` here, right?
                }
            }
        }
        return Promise.all(results);
    });
};