Getting user input till I meet a condition in python

Question

I'm trying to write a code where the program keeps getting the user input in integers and adds it to an empty array. As soon as the user enters "42", the loop stops and prints all the collected values so far.

Ex:
Input:

Output:

1 2 3 78 96

Here is my code (which isn't working as expected):

num = []

while True:
  in_num = input("Enter number")
  if in_num == 42:
    for i in num:
      print (i)
    break
  else:
    num.append(in_num)

you have to convert the input to `int`eger because by default, it is a string. — Ma0, Feb 14 '18 at 11:52
`in_num` is a string, you can't compare strings to numbers. Since you want to stop when the user inputs the string "42" your test should do that, rather than comparing to the integer object 42. — PM 2Ring, Feb 14 '18 at 11:52
You get a string when you do `input`. Cast it to an int like `in_num = int(input('Enter number'))` — tayfun, Feb 14 '18 at 11:52
Also see https://stackoverflow.com/questions/20449427/how-can-i-read-inputs-as-integers — PM 2Ring, Feb 14 '18 at 12:23

score 2 · Answer 1 · answered Feb 14 '18 at 11:57

Here is one solution, which also catches errors when integers are not entered as inputs:

num = []

while True:
    try:
        in_num = int(input("Enter number"))
        if in_num == 42:
            for i in num:
                print(i)
            break
    except ValueError:
        print('Enter a valid number!')
        continue
    else:
        num.append(in_num)

score 0 · Answer 2 · answered Feb 14 '18 at 12:06

0

I think your issue is with the if condition: Input builtin function returns a string and you are comparing it with an integer.

in_num = None    
num = []    

while True:
    in_num = input("Enter number: ")
    if in_num == "42": #or you could use int(in_num)
        for i in num:
            print(i)
        break
    else:
        num.append(in_num)

answered Feb 14 '18 at 12:06

Cibgks

125
6

probably every possible answer is in the comments now. This does not add anything new. -1 – Arpit Solanki Feb 14 '18 at 12:08
Maybe I was answering and had to do some work in the meanwhile? – Cibgks Feb 14 '18 at 12:11
1

You should not do like this. OP clearly saying he want to add input in `integers`. he may want to do some thing with that array. in my opinion it will mislead the OP because string and integers difference is there. – Vikas Periyadath Feb 14 '18 at 12:15
If you wait 16 mins for answering a question then someone else will answer it. Either way the question is not good – Arpit Solanki Feb 14 '18 at 12:16

cholox · Answer 3 · 2018-02-14T11:57:38.267

-1

The problem is, that input is giving you a string and you check in line 5 for an int. You have to replace it to if in_num == "42" or directly convert your input("Enter number") to an int using int(input("Enter number"))

edited Feb 14 '18 at 11:57

answered Feb 14 '18 at 11:53

cholox

13
1
4

why convert a string to a string ???? – bruno desthuilliers Feb 14 '18 at 11:56
@brunodesthuilliers Thanks for mentioning! Meant to convert it to an integer. Corrected my answer – cholox Feb 14 '18 at 11:58

Getting user input till I meet a condition in python

3 Answers3