php mysql - insert one query from a while loop

Question

I have a loop and submit form. I want to insert one query from a variable but when I click on the submit button last one (id number) variable inserts to the database and when I move $_POST['submit'] part inside the while all ID's insert to the database. How can I insert one of the variables from loop?

This is the while part:

<?php
    $supql="SELECT * FROM `tbl_users_posts`";
    $rez=mysqli_query($conn,$supql);
    while ($row=mysqli_fetch_assoc($rez)) {
        $psid=$row['id'];
        echo $row['post'];
?>
<form id="form1" name="form1" method="post">
  <input type="submit" name="submit" id="submit" value="Submit">
</form>                             
<?php } ?>

And this is the submit part:

if (isset($_POST['submit'])) {
    $pid=$_POST['postid'];
    $inslik="INSERT INTO t_plik (pid,uid)VALUES('$psid','$uid')";
    mysqli_query($conn,$inslik);
}

thanks

<?php
$conn=mysqli_connect('localhost','root','','sitn');mysqli_set_charset($conn,"utf8");
$supql="SELECT * FROM `tbl_users_posts`";
$rez=mysqli_query($conn,$supql);
while ($row=mysqli_fetch_assoc($rez)){
    $psid=$row['id'];
    echo $row['post'];
    ?>
    <form id="form1" name="form1" method="post">
    <input type="hidden" name="postid" value="<?php echo $psid; ?>">
    <input type="submit" name="submit" id="submit" value="Submit">
    </form>                 
    <?php }?>
<?php                                       
if(isset($_POST['submit'])){
    $pid=$_POST['postid'];
    $inslik="INSERT INTO t_plik (pid,uid)VALUES('$psid','$uid') ";
    mysqli_query($conn,$inslik);
}?>

Not your answer, but very important: Your code is vulnerable to [SQL Injection](https://stackoverflow.com/questions/332365/how-does-the-sql-injection-from-the-bobby-tables-xkcd-comic-work). Please fix it by using [prepared statements](http://php.net/manual/pt_BR/mysqli.quickstart.prepared-statements.php) — Elias Soares, Feb 14 '18 at 20:53

Barmar · Accepted Answer · 2018-02-14T21:14:23.493

2

Your form has no input with name="postid", so $_POST['postid'] wasn't being set. You can send this with a hidden input.

<form id="form1" name="form1" method="post">
  <input type="hidden" name="postid" value="<?php echo $psid; ?>">
  <input type="submit" name="submit" id="submit" value="Submit">
</form>

The form should still be in the while loop, so you'll get a separate form for each post.

You also have a typo in the code that does the inserting:

$pid=$_POST['postid'];

should be:

$psid=$_POST['postid'];

So you weren't inserting the ID that was submitted.

edited Feb 14 '18 at 21:14

answered Feb 14 '18 at 19:28

Barmar

741,623
53
500
612

doesnt change any thing! – 11111111111111111 Feb 14 '18 at 19:36
It should fix it. Your form has no `name="postid"`, so nothing gets put into `$_POST['postid']`. This fixes that. – Barmar Feb 14 '18 at 19:44
when i click on the submit button, inserts 20-30 query with 12-13-14-15... numbers – 11111111111111111 Feb 14 '18 at 19:50
I don't see any way that could happen from one submit, unless you have the `INSERT` in a loop. – Barmar Feb 14 '18 at 19:50
I think you need to post more of the script, there's more going on than what you posted. – Barmar Feb 14 '18 at 19:51
i added all in the end of first post – 11111111111111111 Feb 14 '18 at 20:01
@behzad Maybe should add: $psid = (isset($psid))?$psid:""; – Malus Jan Feb 14 '18 at 20:04
@behzad Have you try this alse: `action=" – Malus Jan Feb 14 '18 at 20:12
@behzad What is `$uid` – Malus Jan Feb 14 '18 at 20:15
@MalusJan undefined,it's not important! – 11111111111111111 Feb 14 '18 at 20:22
I still don't see any way that can do more than one insert each time you click submit. What do you see if you add `echo "Inserting $psid
";` before the `INSERT` query? – Barmar Feb 14 '18 at 20:37
echo "Inserting $psid
"; show one by one number "Inserting 1-2-3..." but submit button insert last one number – 11111111111111111 Feb 14 '18 at 20:54
Are you saying that it's displaying the "Inserting" message even when you didn't click the Submit button? – Barmar Feb 14 '18 at 20:56
yes! i do put echo "Inserting $psid
"; after the echo $row['post']; . – 11111111111111111 Feb 14 '18 at 21:04
I just added to my answer. You were setting the wrong variable in before the insert. – Barmar Feb 14 '18 at 21:14
i change $pid to $psid and it works! i cant bleave that. thanks – 11111111111111111 Feb 14 '18 at 21:21

php mysql - insert one query from a while loop

1 Answers1