5

I'm using JPA through the Play Framework.

I'm checking to see if a User object is cached, and if so I retrieve it and merge() it such that I can update fields and save the changes later:

user = (User) Cache.get("user-auth-" + sessionAuthToken);
if (user != null) {
    user = user.merge();  // I believe this is the same as EntityManager.merge()
}

However when I do this I get the following error:

PersistenceException occured : 
  org.hibernate.exception.ConstraintViolationException: 
    could not insert: [models.User]
...
Caused by: com.mysql.jdbc.exceptions.jdbc4.
   MySQLIntegrityConstraintViolationException: 
     Duplicate entry '1235411688335416533' for key 'authToken'

It seems like its trying to insert a new user, even though this user should be, and is already in the database. Why would merge() do that?

Or perhaps I'm going about this entirely the wrong way - advice would be appreciated.

sanity
  • 35,347
  • 40
  • 135
  • 226
  • Is `authToken` a primary key? – axtavt Feb 03 '11 at 18:00
  • Not a primary key, but there is a Unique constraint on it – sanity Feb 03 '11 at 20:04
  • @sanity -- next time you have a Hibernate issue, perhaps you should mention that fact. JPA is an interface, your trouble is with the Hibernate implementation. A few details as to entity definition wouldn't hurt, either -- see my answer below which identifies the probably cause of your problem. – Thomas W Feb 20 '13 at 02:10

5 Answers5

4

I think it may be a poblem with hashCode() and equals(). If there are not implemented correctly, a new entity my be inserted instead of updateing an existing one.

Christian Kuetbach
  • 15,850
  • 5
  • 43
  • 79
  • 1
    This would mean, you can't compare or store two unsafed entites within a set, because they would be `euqal` unless you generate a `UUID` in the object constructor. (But this would not lead to your problem) – Christian Kuetbach Feb 04 '11 at 07:43
3

I believe your problem is the way Play manages the JPA environment (and transactions).

Once you receive a request the framework immediately creates the JPA manager and a transaction. From that moment onwards all your Model entities are automatically linked to the manager.

Play facilitates working with this model in 2 ways:

  • You have to explicitly indicate that you want to save changes to an object (via save())
  • Transaction is committed automatically unless there is an exception or you flag it for rollback (JPA.setRollbackOnly())

By running "merge" you are trying to add to the Manager an entity which is already there, which causes the unique key exception. If you just load the entity from the cache, you will be able to modify and call save() once done, and it will work.

Pere Villega
  • 16,429
  • 5
  • 63
  • 100
1

It's an entity definition problem; specifically with regard to primary key/ unsaved values.

The entity definition needs to be correct, for Hibernate to recognize it as 'already saved'. For example, having 'null' in a nullable version field can cause Hibernate to disregard any existing ID & regard it as unsaved.

This is a Hibernate question, not just JPA. JPA is the interface -- you're having trouble with a specific implementation.

Thomas W
  • 13,940
  • 4
  • 58
  • 76
1

See What is the proper way to re-attach detached objects in Hibernate?. Merge tries to write the stale state to the db in order to overwrite possible other concurrent updates. The linked question mentions session.lock(entity, LockMode.NONE); as a possible solution, I haven't tried it though.

Community
  • 1
  • 1
Alexander Torstling
  • 18,552
  • 7
  • 62
  • 74
1

If authToken is not a primary key, then perhaps primary key of the User instance being merged doesn't match the primary key of its counterpart in the database, therefore merge() thinks that it's a new User and tries to insert it.

So, check the primary key of the User, perhaps it have been corrupted or lost somehow.

axtavt
  • 239,438
  • 41
  • 511
  • 482