Call to function in function in class (PHP)

Question

Very simple setting, but I simply don't get it...

functions.php

class functions {
    function output_functions() {
        function sendMail($to, $subject, $message){
            //...code...
        }
    }
}

myfile.php

include $_SERVER['DOCUMENT_ROOT'] ."some/subfolders/functions.php";

$myFunction = new functions();
$myFunction->output_functions()->sendMail("mail@mail.com","My Subject","My Message");

And I'm getting the Error:

Call to a member function sendMail() on null

Any help will be highly appreciated!

wrong syntax and mistakes ; `sendMail` has been declared as an inner, private function, inside `output_functions` so you can't access it outside. and by the way, `output_functions` returns nothing, so this is also nonsense. — Pierre, Feb 21 '18 at 13:21
You would probably be better of (?) creating a separate class `output_functions` if you needed to split them from other types of methods. — Nigel Ren, Feb 21 '18 at 13:23
@Pierre unfortunately it's not nonsense, this file is used in TYPO3. To use these functions they actually have to be nested this way. — user3532637, Feb 21 '18 at 13:36
@Bits Please I already tried. It's not possible to make sendMail() public. — user3532637, Feb 21 '18 at 13:38
@Nigel Ren Unfortunately I can't change the scructure (TYPO3 requirement) — user3532637, Feb 21 '18 at 13:39

score 2 · Accepted Answer · answered Feb 21 '18 at 13:27

2

If you want to group your functions by type (output_functions, input_functions, whatever) I'd do a different class for each. You then should define them as public or private.

As it already has been said, nested functions cannot be accesed from outside, they're just available inside the scope of the function in which they are defined.

answered Feb 21 '18 at 13:27

jonas3344

201
1
7

Thanks! I think, this is it. It's no possible to access nested function from outside. – user3532637 Feb 21 '18 at 13:40
so this was really nonsense the way you wrote it on your post ! – Pierre Feb 21 '18 at 14:19

score 0 · Answer 2 · answered Feb 21 '18 at 13:26

0

Where did you find such a syntax?

class Helper_Output {

  static public function sendMail($to, $subject, $message){
            //...code...
        }
}

//and usage: 
Helper_Output::sendMail("mail@mail.com","My Subject","My Message");

answered Feb 21 '18 at 13:26

bato3

2,695
1
18
26

Just a opinion but static methods are bad for testing / code reuse. – Niclas Larsson Feb 21 '18 at 13:33
Thanks for your input. I found it here: https://stackoverflow.com/a/19232836/3532637 – user3532637 Feb 21 '18 at 13:43

score 0 · Answer 3 · answered Feb 21 '18 at 13:30

0

class Methods1 {
  public function do1() {
    echo __FUNCTION__ . PHP_EOL;
  }

  public function do2() {
    echo __FUNCTION__ . PHP_EOL;
  }
}

class Methods2 {
  public function do1() {
    echo __LINE__ . PHP_EOL;
  }

  public function do2() {
    echo __LINE__ . PHP_EOL;
  }
}

class Factory {
  public function getMethods1() {
    static $cache = new Methods1;

    return $cache;

  }

  public function getMethods2() {
    static $cache = new Methods2;

    return $cache;

  }
}

Usage:

$factory = new Factory;
$factory->getMethods1()->do1();
$factory->getMethods1()->do2();
$factory->getMethods2()->do1();
$factory->getMethods2()->do2();

answered Feb 21 '18 at 13:30

Niclas Larsson

1,317
8
13

It's generally a good idea to include at least some explanation of how the solution works and how it solves OP's problem – William Perron Feb 21 '18 at 13:39
@WilliamPerron yes, but this code is so simple and self explaining. Two methods that returns two different classes with different methods. Just as the topic creator wanted to do. – Niclas Larsson Feb 21 '18 at 15:17

Call to function in function in class (PHP)

3 Answers3