Unable to get rid of errors even after using the right headers

Question

I've just started learning how to program in C, I'm not able get rid of the error. Here's my program:

/* This program rolls two dice and presents the total. It then asks the user 
to guess if the next total will be higher, lower, or equal. It then rolls 
two more dice and tells the user how they did. */

#include<stdio.h>
#include<stdlib.h>
#include<string.h>

int main(void)
{
    int  dice1, dice2, total, total1= 0;
    char ans[25], dans[25];
    char higher[] = "HIGHER", lower[] = "LOWER", equal[] = "EQUAL";

    //the following 3 lines, throws the dice and adds them. 
    dice1 = (rand() % 5) + 1;
    dice2 = (rand() % 5) + 1;
    total = dice1 + dice2;

    //the next few ask the question. 
    printf("Will the next number be higher, lower or equal to %d ?\n", total);
    puts("Type higher, lower or equal.");
    // scanf("&s", ans); //had to remove this line, because apparently we can't use &s to get the string input

    fgets(ans, 25, stdin);
    strcpy(dans, strupr(ans));

    //the next few throw the dice two more times
    dice1 = (rand() % 5) + 1;
    dice2 = (rand() % 5) + 1;
    total1 = dice1 + dice2;

    /*All of these check if the user input matches the actual output and 
    then tells the user if he/she was right.*/
    printf("The upper string is %s.\n", ans);
    if ((ans == higher) && (total1 > total))
    {
        printf("You're right, it is higher!\n");
    }
    else if ((ans == lower) && (total1 < total))
    {
        printf("You're right, it is lower!\n");
    }
    else if ((ans == equal) && (total1 = total))
    {
        printf("You're right. they are equal!\n");
    }
    else
    {
        printf("Your prediction was wrong.\n");
    }



}

The errors which I'm getting:

test.c:25:22: error: implicit declaration of function 'strupr' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
   strcpy(dans, strupr(ans));

                 ^
test.c:25:22: error: incompatible integer to pointer conversion passing 'int' to parameter of type 'const char *' [-Werror,-Wint-conversion]
   strcpy(dans, strupr(ans));

                 ^~~~~~~~~~~
/usr/include/string.h:129:70: note: passing argument to parameter '__src' here extern char *strcpy (char *__restrict __dest, const char *__restrict __src)
                                                                ^
test.c:33:18: error: array comparison always evaluates to false [-Werror,-Wtautological-compare]
   if ((ans == higher) && (total1 > total))

           ^
test.c:37:23: error: array comparison always evaluates to false [-Werror,-Wtautological-compare]
   else if ((ans == lower) && (total1 < total))

              ^
test.c:41:23: error: array comparison always evaluates to false [-Werror,-Wtautological-compare]
   else if ((ans == equal) && (total1 = total))

Please help me with the errors.

Also,

strupr is supposed to be there in stdlib, why am I still getting an error?
When I convert a string to an uppercase string how does it change to int?
Why am I not able to use %s in scanf? (I have used this before)

Thank you.

`strupr()` is not a standard C function, though it is, I believe, found in MS C. Because it isn't declared, the C compiler assumes it returns an `int`, which isn't appropriate for the arguments to `strcpy()`. And the rest of the problems seem to be because you're not using `strcmp()` to compare strings. You'll also need to deal with the newline that `fgets()` keeps in the input data. — Jonathan Leffler, Feb 22 '18 at 06:04
Possible duplicate of [strupr() and strlwr() in string.h part are of the ANSI standard?](https://stackoverflow.com/questions/26327812/strupr-and-strlwr-in-string-h-part-are-of-the-ansi-standard) — DYZ, Feb 22 '18 at 06:04
to check if strings are equal, use [`strcmp`](https://linux.die.net/man/3/strcmp) — yano, Feb 22 '18 at 06:06
`ans == higher` is not the right way to compare strings. `ans` and `higher` are pointers to two distinct arrays. These pointers are never equal. You should use `strcmp(ans, higher)`. And there is no standard function in C to convert a string to the upper case. — DYZ, Feb 22 '18 at 06:06
This looks bad: (total1 = total)) . Not the cause of the warnings, but probably not what you want. PS: Ditch all the redundant (). if (a > b || c < d) is much more readable than if ((a > b) || (c < d)) — Bjorn A., Feb 22 '18 at 06:28
seems you use five sided dice... it should be `rand()%6+1` rand()%6 give a value in the range [0,5] — AndersK, Feb 22 '18 at 08:05

score 3 · Answer 1 · answered Feb 22 '18 at 07:35

3

[answering one question of the this multi-question question]

Why am I not able to use %s in scanf?

You can, but in fact you use &s

  // scanf("&s", ans); //had to remove this lin

which not the same as %s.

answered Feb 22 '18 at 07:35

alk

69,737
10
105
255

alk · Answer 2 · 2018-02-25T15:47:20.437

[answering another question of the this multi-question question]

error: implicit declaration of function 'strupr' is invalid in C99 [-Werror,-Wimplicit-function-declaration]

The above message tells you that the compilers sees strupr the very 1st time in this line. So it "implicitly declares it. Not knowing better it assume this function returns int. To do so is mandated by the C Standard.

So the next time the compiler sees strupr() is takes to to return an int and with this issues the warning

error: incompatible integer to pointer conversion passing 'int' to parameter of type 'const char *' [-Werror,-Wint-conversion]

telling you that an int passed as 2nd parameter to strcpy() is not what is expected.

All this points to the fact that the C implementation you are using does not provide a function called strupr(). This is perfectly fine, as the C Standard does not know this function.

You can get around this by rolling your own like for example so:

char * strupr(char * s)
{
  assert(s);

  char * pc = s;
  while (*pc)
  {
    *pc = toupper(*pc); /* toupper() requires <ctype.h> */
    ++pc;
  }

  return s;
}

score 2 · Accepted Answer · answered Feb 22 '18 at 08:56

You have a number of issues to address. Your use of strupr is not a standard C function and may only be available on windoze. Your alternative that are standard are to write a short function and either use the functions isupper() or islower() from the header <ctype.h> to loop over each character and calling toupper() if a change from lower-case to upper-case is required.

A short function can do all of that for you in a very efficient manner. Something like:

/** convert string to uppercase.
 *  returns string with all chars converted to uppercase.
 */
char *str2upper (char *str)
{
    if (!str) return NULL;

    char *p = str;

    for ( ; *p; p++)
        if ('a' <= *p && *p <= 'z')
            *p += 'A' - 'a';

    return str;
}

is all you need. It simply walks the string provided as input and if the character is lowercase, converts it to uppercase.

Your next problem is how you handle the buffer filled by fgets. Being a line-oriented input function, it will read up to and including the '\n' at the end of the input, including that as your final character in asn. Now no matter what you do with your conversion, dans will never match higher or lower or equal -- you figure out why yet?

Let's look at your `higher'

'H','I','G','H','E','R'

Now lets look at dans if it contained the same word (but with the '\n' character still dangling off the end):

'H','I','G','H','E','R','\n'

Since you read with fgets and did not remove the trailing '\n', it will always prevent a valid comparison between dand and any of your strings. How to fix it?

Simple, just check that the last character in the ans as filled by fgets is the '\n' and overwrite the '\n' with a nul-terminating character removing it. (additionally, you should check that the user didn't cancel the input by generating a manual EOF to quit early. You can do all those things in a simple little input loop while requiring your user to enter a valid string until he does or decides to cancel, e.g.

    if (!fgets (ans, 25, stdin)) {  /* check for user cancle with EOF */
        fprintf (stderr, "user canceled input.\n");
        return 1;
    }
    size_t len = strlen (ans);          /* get string length */
    if (len && ans[len - 1] == '\n')    /* valisate last char is '\n' */
        ans[--len] = 0;                 /* overwrite with nul-character */
    else    /* warn if chars can remain unread (input too long) */
        fprintf (stderr, "unread characters may remain in stdin.\n");

    strcpy(dans, str2upper(ans));

Now dans is properly uppercase and has no '\n' dangling off its tail-end.

Your comparisons are the last problem area. You cannot check string equality with the == operator. (that is for comparing a character at a time, not a string. The strcmp function in string.h is the proper tool here. If the strings compare equally, strcmp returns 0. With that in mind you can fix your comparisons with:

    /*All of these check if the user input matches the actual output and 
    then tells the user if he/she was right.*/
    printf("The upper string is %s.\n", ans);
    if (strcmp (dans, higher) == 0 && (total1 > total))
    {
        printf("You're right, it is higher!\n");
    }
    else if (strcmp (dans, lower) == 0 && (total1 < total))
    {
        printf("You're right, it is lower!\n");
    }
    else if (strcmp (dans, equal) == 0 && (total1 == total))
    {
        printf("You're right. they are equal!\n");
    }
    else
    {
        printf("Your prediction was wrong.\n");
    }

Now putting it altogether, you have your code in a form that should work, e.g.

#include<stdio.h>
#include<stdlib.h>
#include<string.h>

/** convert string to uppercase.
 *  returns string with all chars converted to uppercase.
 */
char *str2upper (char *str)
{
    if (!str) return NULL;

    char *p = str;

    for ( ; *p; p++)
        if ('a' <= *p && *p <= 'z')
            *p += 'A' - 'a';

    return str;
}

int main(void)
{
    int  dice1, dice2, total, total1= 0;
    char ans[25] = {0}, dans[25] = {0};
    char higher[] = "HIGHER", lower[] = "LOWER", equal[] = "EQUAL";

    //the following 3 lines, throws the dice and adds them. 
    dice1 = (rand() % 5) + 1;
    dice2 = (rand() % 5) + 1;
    total = dice1 + dice2;

    //the next few ask the question. 
    printf("Will the next number be higher, lower or equal to %d ?\n", total);
    fputs ("Type higher, lower or equal: ", stdout);

    if (!fgets (ans, 25, stdin)) {  /* check for user cancle with EOF */
        fprintf (stderr, "user canceled input.\n");
        return 1;
    }
    size_t len = strlen (ans);          /* get string length */
    if (len && ans[len - 1] == '\n')    /* valisate last char is '\n' */
        ans[--len] = 0;                 /* overwrite with nul-character */
    else    /* warn if chars can remain unread (input too long) */
        fprintf (stderr, "unread characters may remain in stdin.\n");

    strcpy(dans, str2upper(ans));

    //the next few throw the dice two more times
    dice1 = (rand() % 5) + 1;
    dice2 = (rand() % 5) + 1;
    total1 = dice1 + dice2;

    /*All of these check if the user input matches the actual output and 
    then tells the user if he/she was right.*/
    printf("The upper string is %s.\n", ans);
    if (strcmp (dans, higher) == 0 && (total1 > total))
    {
        printf("You're right, it is higher!\n");
    }
    else if (strcmp (dans, lower) == 0 && (total1 < total))
    {
        printf("You're right, it is lower!\n");
    }
    else if (strcmp (dans, equal) == 0 && (total1 == total))
    {
        printf("You're right. they are equal!\n");
    }
    else
    {
        printf("Your prediction was wrong.\n");
    }
}

Example Use/Output

$ ./bin/rolldice
Will the next number be higher, lower or equal to 6 ?
Type higher, lower or equal: lower
The upper string is LOWER.
You're right, it is lower!

Look things over and let me know if you have additional questions.

Unable to get rid of errors even after using the right headers

3 Answers3