Comparision between 2 Object

Question

I am working on a course registration system.I need to check for time conflicts.

Already registered courses object:

{"00001":{"days":"Monday-Tuesday","hours":"11:40-12:30*13:40-15:30"}}

this means that 00001 course is in monday 11:40-12:30 in tuesday 13:40-15:30

Courses to register object:

{"00003":{"days":"Friday","hours":"9:40-10:40"}}

I have managed to check is student already registered to course with this code:

Object.keys(registeredcoursesobject).forEach(function(key){
    if( Object.keys(coursestoregisterobject).includes(key)) {
      alert("You have already registered to "+key+" crn number course");

      //return;
    }
  });

A course can be at most 2 days in a week and in 1 different time intervals(what if 2 time intervals??) which means that there will be only one "-" in days property and only one "*" in hours property. I am new to programming and working on this for days any ideas ?

Answer 1

I hope this answer is still relevant for you. Here is what I have:

var registeredcoursesobject = {"00001":{"days":"Monday-Thursday","hours":"11:40-12:30*16:30-18:30"}}
var coursestoregisterobject = {"00002":{"days":"Monday-Friday","hours":"10:40-15:30*16:40-18:00"}}

var getTicks = function(timeStr) {
    return new Date('1970-01-01T' + timeStr + ':00Z').getTime();
}

Object.keys(registeredcoursesobject).forEach(function(rKey){
    if( Object.keys(coursestoregisterobject).includes(rKey)) {
        alert("You have already registered to "+rKey+" crn number course");
        return false;
    };
    Object.keys(coursestoregisterobject).forEach(function(cKey){
        var regDays = registeredcoursesobject[rKey].days.split('-');
        var regHours = registeredcoursesobject[rKey].hours.split('*');

        var courseDays = coursestoregisterobject[cKey].days.split('-');
        var courseHours = coursestoregisterobject[cKey].hours.split('*');

        regDays.forEach(function(rDay, i) {
            var rHourRange = regHours[i];

            // I assume you need to check there is same date/time pain in registeredcoursesobject and coursestoregisterobject
            courseDays.forEach(function(cDay, j) {
                if (rDay == cDay) {
                    var cHourRange = courseHours[j];
                    // now, do you need to compare hours be equal exactly or do you need to check time overlap?
                    // assume you just need to ckeck hour ranges are equal, then:
                    if (rHourRange == cHourRange){
                        // means equal
                        alert("You have already registered to "+cKey+" crn number course on day "+cDay+" at "+cHourRange+" hours.");
                        return true;
                    }

                    // if you need to check range overlap
                    var rTime = rHourRange.split('-');
                    rTimeRange = [getTicks(rTime[0]), getTicks(rTime[1])];
                    rStartT = Math.min.apply(null, rTimeRange), rEndT = Math.max.apply(null, rTimeRange);
                    var cTime = cHourRange.split('-');
                    cTimeRange = [getTicks(cTime[0]), getTicks(cTime[1])]
                    cStartT = Math.min.apply(null, cTimeRange), cEndT = Math.max.apply(null, cTimeRange);

                    // now your rangeTime is a pair of int values, that represent time range rStartT:rEndT
                    // and your courseTime is a pair of int values cStartT:cEndT
                    // so now you just check the overlap of two integer pais.
                    // according to this: https://stackoverflow.com/questions/3269434/whats-the-most-efficient-way-to-test-two-integer-ranges-for-overlap#answer-3269471
                    if (rStartT < cEndT && cStartT < rEndT) {
                        alert("You have already registered to "+cKey+" crn number course on day "+cDay+" within time range "+cHourRange+" hours overlap with "+rHourRange+" time range.");
                        // means time ranges are overlap at some range. But I don't count the border, like "14:00-15:00" and "15:00-16:00" do not overlap
                        // otherwise replace < with <=
                        return true;
                    }
                }
            })
        });
        return false;
    });
});

I am making some assumptions here about your task.

UPDATE: added time range check. UPDATE: check keys equal first and values swap if start time is for some reason is bigger than end time.