if condition in Python's list comprehension is not working

Question

I have the following simple code in python giving SyntaxError: invalid syntax

I want a new list with non zero values.

data = [11,2,0,34,8,4]
new_data = [ if x for x in data  ]
print( new_data )

score 1 · Answer 1 · answered Feb 28 '18 at 17:27

1

Here is how to do this:

new_data = [x for x in data if x != 0]

answered Feb 28 '18 at 17:27

Phydeaux

4

Or just `... if x]`, that part of the logic wasn't a problem. – jonrsharpe Feb 28 '18 at 17:33
@jonrsharpe either will work, but that will also work for anything that evaluates to `True`. If we are working with numeric values, I think we should write what we mean. – Phydeaux Feb 28 '18 at 17:35
But with numeric values, `if x` _is_ exactly what we mean. – user3483203 Feb 28 '18 at 17:37
@chrisz explicit is better than implicit – Phydeaux Feb 28 '18 at 17:38
is this the reason for the downvotes? – Phydeaux Feb 28 '18 at 17:38
Not the downvoter, but sometimes answers to low effort duplicate questions are downvoted. – user3483203 Feb 28 '18 at 17:40
@chrisz ¯\\_(ツ)_/¯ – Phydeaux Feb 28 '18 at 17:41
3

@Phydeaux I downvoted for this answer not being particularly useful. – miradulo Feb 28 '18 at 17:42
@miradulo because it is incorrect, or because you think no-one should answer questions like this? – Phydeaux Feb 28 '18 at 17:43

1 Answers1