Spring Service not rolling back the transaction after exception

Question

I am using Spring JpaRepository for CRUD implementation in one of my App screens. As a part of that, I am developing a feature where user can save all Car entities or nothing (should roll back) into database. I am not sure how do I achieve this functionality using Spring Boot, Spring Rest, Spring Jpa.

Below is my source code.

@Repository
interface CarRepository extends JpaRepository<Car, Integer> { }

@Service
class CarService {

    @Autowired
    CarRepository repo;

    @Transactional(rollbackFor=RuntimeException.class)
    public List<Car> saveAllOrNone(List<Car> cars) {
        for(Car car: cars) {
            repo.save(car);
        }
    }
}

I am unable to figure out what wrong I am doing.

When I tested it using two different data among which 1 have invalid data, the other record is getting inserted into database instead of being rolled back.

In addition to this, I am getting an Exception like UOWManager transaction processing failed:nested exception is com.ibm.wsspi.uow.UOWException: javax.transaction.RollbackException

Please help me out. Thank you.

I don't understand the problem. Does the rollback is not working? What happens instead? — Dherik, Mar 01 '18 at 18:20
The rollback only occurs when there is some error inside the transaction. Is the error occur when you persist the cars? — Dherik, Mar 01 '18 at 19:18
yeah, I have tested it purposely using invalid data like First name set to null. — Dilip Kumar, Mar 01 '18 at 19:23
Try to use `repo.save(cars)`, without the iterator. Also, try to add the `@EnableTransactionManagement` on your Application. — Dherik, Mar 01 '18 at 19:36
Oh my god, it worked like anything, i am really thankful to you Dherik, — Dilip Kumar, Mar 01 '18 at 20:00
Can you please make a moment to explain me what was the wrong I did. — Dilip Kumar, Mar 01 '18 at 20:01

score 2 · Accepted Answer · answered Mar 26 '18 at 21:10

2

Even though its late, I would like to post the answer because someone would find this useful. I fixed the error by implementing a JPA Transaction Manager in my spring boot application using the resource here

answered Mar 26 '18 at 21:10

Dilip Kumar

65
1
10

score 0 · Answer 2 · answered Mar 01 '18 at 20:12

0

Seems the @Transactional is not working for you. I could understand that there is some configuration in your application that could be the responsible to not create the DataSourceTransactionManager. As explained here, this should be automatically:

Spring Boot will detect spring-jdbc on the classpath and h2 and will create a DataSource and a JdbcTemplate for you automatically. Because such infrastructure is now available and you have no dedicated configuration, a DataSourceTransactionManager will also be created for you: this is the component that intercepts the @Transactional annotated method

So I see two alternatives to resolve your problem.

The first is use the save method from Spring Repository that could accept your car list:

repo.save(cars);

This will work because the Spring has an internal @Transactional for the repository methods.

The another alternative is add together with your @SpringBootApplication the annotation @EnableTransactionManagement, enabling manually what Spring should do for you.

More details here.

answered Mar 01 '18 at 20:12

Dherik

17,757
11
115
164

I have also tried removing the `@EnableTransactionManagement` annotation on `@SpringBootApplication`, it worked. So, i should have not iterated it explicitly using For each loop. Thanks a lot Dherik. – Dilip Kumar Mar 01 '18 at 20:43
oh no, the roll back is happening as expected, but, the exception is appearing again and again, i tried removing the `@Transactional` annotation on the Service method, then its throwing Exception like `Exception caught from before_synchronization operation: java.lang.UnsupportedOperationException`. – Dilip Kumar Mar 01 '18 at 21:02
Stacktrace is: `Exception caught from before_synchronization operation: java.lang.UnsupportedOperationException at org.hibernate.engine.transation.jta.platform.internal.WebsphereJtaExtendedPlatform.TransactionManagerAdaptor.setRollBackOnly` – Dilip Kumar Mar 01 '18 at 21:10
@DilipKumar i think that your problem is with the WebSphere: https://stackoverflow.com/a/38173907/2387977 – Dherik Mar 01 '18 at 21:17
I am not getting the details give in the post but, Is this error something that is expected or to be ignored? – Dilip Kumar Mar 01 '18 at 21:34
Hi Dillip, I can't say exactly. But seems that could be ignored. – Dherik Mar 01 '18 at 21:43
I have fixed the Websphere error by referring to the [link](https://stackoverflow.com/questions/13388069/unexpected-unsupportedoperationexception-on-hibernate-validation-failure). Now, the above error does not appear but still, the roll back is not happening for me. – Dilip Kumar Mar 02 '18 at 13:41

Spring Service not rolling back the transaction after exception

2 Answers2