Not able to open PDF in the app

Question

This is a continuation from my previous quesion. I wanted to open the pdf in the app instead of opening it with third-party apps. I've rewritten the code so that pdf files in assets folder can be copied into sd card.
Here is my code:

package com.dell.pdfreader;

import android.Manifest;
import android.content.Context;
import android.content.Intent;
import android.content.pm.PackageManager;
import android.content.res.AssetManager;
import android.net.Uri;
import android.os.Bundle;
import android.os.Environment;
import android.support.v4.content.ContextCompat;
import android.support.v7.app.AppCompatActivity;
import android.util.Log;
import android.view.View;
import android.widget.Button;

import net.sf.andpdf.pdfviewer.PdfViewerActivity;

import java.io.File;
import java.io.FileOutputStream;
import java.io.IOException;
import java.io.InputStream;
import java.io.OutputStream;

public class PdfMainActivity extends AppCompatActivity implements View.OnClickListener {

    private static String TAG = PdfMainActivity.class.getCanonicalName();

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_pdf_main);

        Button click = (Button) findViewById(R.id.click);
        click.setOnClickListener(this);

    }

    @Override
    public void onClick(View view) {
        Context mContext = getApplicationContext();
        switch (view.getId()) {
            case R.id.click:
                try {

                    AssetManager assetManager = getAssets();
                    String[] files = null;
                    try {
                        files = assetManager.list("pdffiles");
                    } catch (IOException e) {
                        Log.e(TAG, e.getMessage());
                    }

                    for (String fileName : files != null ? files : new String[0]) {
                        InputStream is = null;
                        OutputStream os = null;

                        try {
                            is = assetManager.open("pdffiles/" + fileName);
                            os = new FileOutputStream(Environment.getExternalStorageDirectory().toString() + "/" + fileName);
                            copyFile(is, os);
                            is.close();
                            os.flush();
                            os.close();
                        } catch (Exception e) {
                            Log.e(TAG, e.getMessage());
                        }
                    }

                    Uri path = Uri.parse(Environment.getExternalStorageDirectory().getAbsolutePath() + File.separator + "Dojo_lab_tour.pdf");
                    String oPath = path.toString();
                    Intent intent = new Intent(PdfMainActivity.this, ReaderActivity.class);
                    if (ContextCompat.checkSelfPermission(PdfMainActivity.this, Manifest.permission.READ_EXTERNAL_STORAGE) != PackageManager.PERMISSION_GRANTED) {
                        intent.setDataAndType(path, "application/pdf");
                        intent.putExtra(PdfViewerActivity.EXTRA_PDFFILENAME, oPath);
                        startActivity(intent);
                    } else {
                        Log.d(TAG, "No permission!");
                    }
                } catch (Exception e) {
                    e.printStackTrace();
                }
        }
    }

    private void copyFile(InputStream is, OutputStream os) throws IOException {
        byte[] buffer = new byte[1024];
        int read;
        while ((read = is.read(buffer)) != -1) {
            os.write(buffer, 0, read);
        }
    }
}

And here is my 2nd activity:

package com.dell.pdfreader;

import android.os.Bundle;

public class ReaderActivity extends net.sf.andpdf.pdfviewer.PdfViewerActivity {

    @Override
    public void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_reader);
    }

    @Override
    public int getPreviousPageImageResource() {
        return R.drawable.left_arrow;
    }

    @Override
    public int getNextPageImageResource() {
        return R.drawable.right_arrow;
    }

    @Override
    public int getZoomInImageResource() {
        return R.drawable.zoom_in;
    }

    @Override
    public int getZoomOutImageResource() {
        return R.drawable.zoom_out;
    }

    @Override
    public int getPdfPasswordLayoutResource() {
        return 0;
    }

    @Override
    public int getPdfPageNumberResource() {
        return 0;
    }

    @Override
    public int getPdfPasswordEditField() {
        return 0;
    }

    @Override
    public int getPdfPasswordOkButton() {
        return 0;
    }

    @Override
    public int getPdfPasswordExitButton() {
        return 0;
    }

    @Override
    public int getPdfPageNumberEditField() {
        return 0;
    }
}

When I run that code, I get this error:

03-05 16:19:43.000 14997-14997/com.dell.pdfreader E/com.dell.pdfreader.PdfMainActivity: /storage/emulated/0/Dojo_Lab_Tour.pdf (Permission denied)
03-05 16:19:43.049 14997-14997/com.dell.pdfreader I/PDFVIEWER: onCreate
03-05 16:19:43.049 14997-14997/com.dell.pdfreader E/PDFVIEWER: restoreInstance
03-05 16:19:43.119 14997-14997/com.dell.pdfreader I/PDFVIEWER: Intent { dat=/storage/emulated/0/Dojo_lab_tour.pdf typ=application/pdf cmp=com.dell.pdfreader/.ReaderActivity (has extras) }
03-05 16:19:43.124 14997-14997/com.dell.pdfreader I/PDFVIEWER: ST='file '/storage/emulated/0/Dojo_lab_tour.pdf' not found'

In mainfest file, I've added these two lines:

<uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE"/>
<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE"/>

How can I fix this error?
EDIT:
My assets folder structure is as given below:

I modified my code as suggested by Tommin and Commonsware:

if (android.os.Build.VERSION.SDK_INT >= android.os.Build.VERSION_CODES.M) {
                        Intent intent = new Intent(PdfMainActivity.this, ReaderActivity.class);
                        if (checkSelfPermission(Manifest.permission.READ_EXTERNAL_STORAGE) == PackageManager.PERMISSION_GRANTED) {
                            intent.setDataAndType(path, "application/pdf");
                            intent.putExtra(PdfViewerActivity.EXTRA_PDFFILENAME, oPath);
                            startActivity(intent);
                        } else {
                            Log.d(TAG, "No permission!");
                        }
                    }

Getting this error now:

03-05 17:45:26.526 7888-7888/com.dell.pdfreader E/com.dell.pdfreader.PdfMainActivity: /storage/emulated/0/Dojo_Lab_Tour.pdf (Permission denied)

@VaradMondkar: When I ran above code in android 6, I got `EACCES` error. When I ran above code in android 7, I got error as shown in question — Ajay Kulkarni, Mar 05 '18 at 11:40
"I already added, please check question" -- there is no code related to runtime permissions in your question. Please check https://stackoverflow.com/questions/32635704/android-permission-doesnt-work-even-if-i-have-declared-it — CommonsWare, Mar 05 '18 at 11:57
@CommonsWare: Added run time permissions, please check edited question — Ajay Kulkarni, Mar 05 '18 at 12:16
It is unclear which statement causes the permission denied. Please tell. Further you have a lot of catch blocks in that onClick() handler but if there is a catch you are just continuing with your code. You should then return of course. Otherwise you get error on error. — greenapps, Mar 05 '18 at 14:14

score 2 · Answer 1 · 2018-03-05T12:31:34.653

1- Add the permissions in your manifest, like you did:

<manifest 
    xmlns:android="http://schemas.android.com/apk/res/android"
    package="com.....">

    <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
    <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" />

2- These 2 permissions are considered to be dangerous permissions, which you should request on the Runtime, on your onClick method for ex:

@Override
public void onClick (View view) {
    if (ContextCompat.checkSelfPermission (PdfMainActivity.this, Manifest.permission.READ_EXTERNAL_STORAGE) != PackageManager.PERMISSION_GRANTED ||
            ContextCompat.checkSelfPermission (PdfMainActivity.this, Manifest.permission.WRITE_EXTERNAL_STORAGE) != PackageManager.PERMISSION_GRANTED) {

        ActivityCompat.requestPermissions (PdfMainActivity.this, new String [] { Manifest.permission.WRITE_EXTERNAL_STORAGE, Manifest.permission.READ_EXTERNAL_STORAGE }, 1000);
        return;
    }
    ...
}

3- Make sure the external storage is writable before copying your stream into it:

if (!isExternalStorageWritable ()) {
    throw new Exception ("External Storage Not Writable");
}

private boolean isExternalStorageWritable () {
    return Environment.MEDIA_MOUNTED.equals (Environment.getExternalStorageState ());
}

4- Your code becomes:

@Override
public void onClick (View v) {
    if (ContextCompat.checkSelfPermission (PdfMainActivity.this, Manifest.permission.READ_EXTERNAL_STORAGE) != PackageManager.PERMISSION_GRANTED ||
            ContextCompat.checkSelfPermission (PdfMainActivity.this, Manifest.permission.WRITE_EXTERNAL_STORAGE) != PackageManager.PERMISSION_GRANTED) {

        ActivityCompat.requestPermissions (PdfMainActivity.this, new String [] { Manifest.permission.WRITE_EXTERNAL_STORAGE, Manifest.permission.READ_EXTERNAL_STORAGE }, 1000);
        return;
    }

    AssetManager assetManager = getAssets ();

    String dir = "pdffiles";

    try {
        String [] paths = assetManager.list (dir);
        for (String path : paths) {
            if (!isExternalStorageWritable ()) {
                throw new Exception ("External Storage Not Writable");
            }

            InputStream is  = assetManager.open (dir + File.separator + path);
            OutputStream os = new FileOutputStream (Environment.getExternalStorageDirectory () + File.separator + path);

            copy (is, os);

            closeQuietly (os, is);
        }
    } catch (Exception e) {
        // TODO Catch your exception here
    }
}

public static int copy (InputStream is, OutputStream os) throws IOException {
    long count = 0;
    int n;

    byte [] buffer = new byte [4 * 1024];

    while (-1 != (n = is.read (buffer))) {
        os.write (buffer, 0, n);
        count += n;
    }

    if (count > Integer.MAX_VALUE) {
        return -1;
    }

    return (int) count;
}

public static void closeQuietly (Closeable... closeables) {
    if (closeables == null || closeables.length == 0) {
        return;
    }
    try {
        for (Closeable closeable : closeables) {
            if (closeable != null) {
                closeable.close ();
            }
        }
    } catch (final IOException ignore) { }
}

5- When trying to read the PDFs, make sure the external storage is readable as well by calling:

private boolean isExternalStorageReadable() {
    String state = Environment.getExternalStorageState ();
    return Environment.MEDIA_MOUNTED.equals (state) || Environment.MEDIA_MOUNTED_READ_ONLY.equals (state);
}

6- Put the copy processing on a background thread not to block the UI. And maybe show a progress Popup to the user.

score 0 · Answer 2 · answered Mar 06 '18 at 07:34

I got it, guys. I modified my code as:

Uri path = Uri.parse(Environment.getExternalStorageDirectory().getAbsolutePath() + File.separator + "EPSF.pdf");
                    String oPath = path.toString();
                    if (android.os.Build.VERSION.SDK_INT >= android.os.Build.VERSION_CODES.M) {
                        if (checkSelfPermission(Manifest.permission.READ_EXTERNAL_STORAGE) != PackageManager.PERMISSION_GRANTED
                                && checkSelfPermission(Manifest.permission.WRITE_EXTERNAL_STORAGE) != PackageManager.PERMISSION_GRANTED ) {
                            ActivityCompat.requestPermissions(PdfMainActivity.this, new String[]{Manifest.permission.WRITE_EXTERNAL_STORAGE, Manifest.permission.READ_EXTERNAL_STORAGE}, 1000);
                            Log.d(TAG, "No permission!");
                        } else {
                            Intent intent1 = new Intent(PdfMainActivity.this, ReaderActivity.class);
                            intent1.setDataAndType(path, "application/pdf");
                            intent1.putExtra(PdfViewerActivity.EXTRA_PDFFILENAME, oPath);
                            startActivity(intent1);
                        }
                    }

I added run time permissions and modified according to what Mehdi had suggested.

Not able to open PDF in the app

2 Answers2