Hibernate Validator takes too much time. Strange issue

Question

I have serious problem with (I guess hibernate validator). I''m using spring boot 2.0 and the problem exists even i spring boot 1.4.x and the correspondent version comes from:

<dependency>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-validation</artifactId>
</dependency>

I have simple domain validation -

ExhibitorListt.class
@Id
@GeneratedValue(strategy = GenerationType.IDENTITY)
@Column(name="id")
private Integer id;


@Column(name="exhibitor_name")
@NotBlank(message="The name of exhibitor cannot be empty!")
private String exhibitorName;


@Column(name="exhibitor_price")
@NotNull(message="Price must be a number")
private Double exhibitorPrice;


@Column(name="catalogue_number")
@NotNull(message="Catalogue number can not be empty!")
private Integer catalogueNumber;

@Column(name="oracle_number")
@NotBlank(message="Oracle number can not be empty")
private String oracleNumber;

And simple Spring MVC controller

@Secured({ "ROLE_ADMIN" })
@RequestMapping(value = "/new", method = RequestMethod.POST)
public String newExhibitor(Model model, @Valid ExhibitorList newExhibitor, BindingResult result, RedirectAttributes attr) {

    if (result.hasErrors()) {
        attr.addFlashAttribute("org.springframework.validation.BindingResult.newExhibitor", result);
        attr.addFlashAttribute("newExhibitor", newExhibitor);
        return "redirect:/exhibitor/new";
    }

    exhibitorListRepository.save(newExhibitor);
    return "redirect:/exhibitor/new";
}

When I try to create new entity, the request takes 10 - 15 sec. I attache profiler to diagnostic the problem. It seems that it comes from hibernate-validation. I cannot reproduce the bug because it is not occurs every time, but from time to time... I tried many things but nothing helps ....

JSON from the profiler with call tree. http://80.241.211.242/sampleCallTree%20(1).json

Any suggestions are OK.

Answer 1

As you can see in your profiling all the time is spent in the class loader loading a resource.

So your issue is not about Hibernate Validator specifically but it appears to be when Hibernate Validator tries to load the resource bundle (to find the localized messages) using the class loader.

It's indeed very strange as it should be fast and I don't see any reason why the class loader could take such an amount of time, apart from I/O issues.

Could you maybe try to build a minimal Spring Boot reproducer?

By the way, @mark_o is right: upgrading to the latest Hibernate Validator 6.0.7.Final will help you as, in the particular case when you define the message manually, we don't load the resource bundle anymore.

That being said, I would advise you to get to the root of this issue as you expose yourself to a lot of problems if loading a single resource from your class loader takes ~15 seconds.