Parse error: syntax error, unexpected 'background' (T_STRING), expecting ','

Question

I am new to PHP and I want to apply If condition to price attribute in magento whenever Price is less than or equals to zero I want a block disappear and show when price attribute is greater than 0 then block should show up

Here is the code If I have done any thing wrong in the code please let me know

<?php
$Flipkart_price >0;
if ( $Flipkart_price >0 ) {
echo"

<div style="background-color:#efefef ; padding:10px"><button type="button" > <img alt="Flipkart" " class="button btn-cart" onclick="setLocation('<?php echo $_product->getStoreurl() ?>');"src="http://res.cloudinary.com/dharvdevi/image/upload/v1519810140/flipkart_store.png">
 </button> 
<?php echo "Price:" . $_product->getFlipkart_price(); ?>
<button type="button" title="<?php ec`enter code here`ho $buttonTitle ?>" class="button btn-cart" onclick="setLocation('<?php echo $_product->getStoreurl() ?>');">
<span><?php echo $buttonTitle ?></span></span>
</button></div> ";
}
?>

You're using double quotes for `echo "...` to print your html, well your html has another double-quote in it at ` — Jason Spradlin, Mar 11 '18 at 09:12
You code has too many errors. My suggestion : Please understand at least the basics of PHP before writing codes. The first comment will take you to the documentation for PHP `echo` function but I think you should also read other PHP functions and understand the standard syntax. — Rajan Benipuri, Mar 11 '18 at 09:14

score 0 · Answer 1 · answered Mar 11 '18 at 09:13

0

You have to take care of the quotes. doing it this way should better work :

<?php
$Flipkart_price = 1;
if ( $Flipkart_price >0 ): ?>
<div style="background-color:#efefef ; padding:10px">
    <button type="button" >
        <img alt="Flipkart" class="button btn-cart" onclick="setLocation('<?php echo $_product->getStoreurl() ?>');" src="http://res.cloudinary.com/dharvdevi/image/upload/v1519810140/flipkart_store.png">
    </button> 
<?php echo "Price:" . $_product->getFlipkart_price(); ?>
<button type="button" title="<?php echo 'enter code here' . $buttonTitle ?>" class="button btn-cart" onclick="setLocation('<?php echo $_product->getStoreurl(); ?>');">
<span><?php echo $buttonTitle; ?></span></span>
</button></div>
<?php endif; ?>

answered Mar 11 '18 at 09:13

kevinniel

1,088
1
6
14

First of All thanks for your quick response. I have tried your code it works but If the price is 0 still div is showing up at the front end but it suppose to disappear How can we do that? – Jiyan Devi Mar 11 '18 at 13:13
then change your conditionnal statement as following : `if($_product->getFlipkart_price() > 0) {}` – kevinniel Mar 11 '18 at 13:38
I have tried but it did not work getFlipkart_price() > 0) {} ?>
getFlipkart_price(); ?>
– Jiyan Devi Mar 11 '18 at 14:16
well it should work... I need more informations to help you figure this out such as error messages if they are some, and also var_dump on `$_product->getFlipkart_price()` – kevinniel Mar 11 '18 at 14:21
Code works, Thanks for your help – Jiyan Devi Mar 12 '18 at 07:40
ok nice, can you tell me where does the error came from ? – kevinniel Mar 12 '18 at 07:42

score 0 · Answer 2 · answered Mar 11 '18 at 09:48

The comments and proposed solutions are right: you have a quote issue.

I suggest to emphasize dramatically the readability of your code as follows:

<?php
  $Flipkart_price = 1;
  if ($Flipkart_price > 0) {
    echo '<div style="background-color:#efefef ; padding:10px">';
    echo '<button type="button">';
    echo '<img alt="Flipkart" class="button btn-cart" '
      . 'onclick="setLocation('
      .   $_product->getStoreurl()
      . ');" '
      . 'src="http://res.cloudinary.com/dharvdevi/' 
      .   'image/upload/v1519810140/flipkart_store.png">';
    echo '</button>';
    echo 'Price:' . $_product->getFlipkart_price();
    echo '<button type="button" ' 
      . "title=\"$buttonTitle\" "
      . 'class="button btn-cart" '
      . 'onclick="setLocation('
      .   $_product->getStoreurl()
      . ');">';
    echo "<span>$buttonTitle</span>"; # one </span> is enough
    echo "</button></div>";
  }
?>

First of All thanks for your quick response. I have tried your code it works but If the price is 0 still div is showing up at the front end but it suppose to disappear How can we do that? — Jiyan Devi, Mar 11 '18 at 13:11
If you set `$Flipkart_price = 1;` just before `if ($Flipkart_price > 0)`, the test will never fail. Adapt this part of the code. — Pierre François, Mar 11 '18 at 15:11

Parse error: syntax error, unexpected 'background' (T_STRING), expecting ','

2 Answers2