conditioned string and variable concatenation

Question

how to concatenate this syntax in controller using php. method 1 :

echo "<option '". if($p_main_cat_id==$value['main_cat_id']){echo 'selected';}."' value='".$value['main_cat_id']."'>".$value['name']."</option>";

//error is : unexpected if

Method 2:

echo "<option '".<?php if($p_main_cat_id==$value['main_cat_id']){echo 'selected';} ?>."' value='".$value['main_cat_id']."'>".$value['name']."</option>";

error is:

unexpected '<'

these both are giving error.please correct it. Thank you!

I called the function of controller in view using JavaScrip and need to return this. That's why i need all these in one — Muhammad Ahtisham, Mar 12 '18 at 13:29
Chris G I didn't understand what are you saying can you please elaborate the last sentance i:e a ? b : c — Muhammad Ahtisham, Mar 12 '18 at 13:30

Eddie · Accepted Answer · 2018-03-12T13:51:39.680

0

You can't append a string to an if condition directly. Unless you are using Ternary Operator

You have to separate into several lines. Like:

Option 1

echo "<option selected='";
if( $p_main_cat_id==$value['main_cat_id'] ) echo 'selected';
echo  "' value='" . $value['main_cat_id'] . "'>" . $value['name'] . "</option>";

Option 2 Ternary Operator

echo "<option selected='" . ( $p_main_cat_id == $value['main_cat_id'] ? 'selected' : '' ) . "' value='".$value['main_cat_id']."'>".$value['name']."</option>";

Option 3

Or you can store the value on a variable and append it.

$isSelected = ""; //Init the variable with empty string. 
if( $p_main_cat_id == $value['main_cat_id'] ) $isSelected = 'selected'; //Use the condition here, if true, assign selected' to the variable

//You can now append the variable here
echo "<option selected='" . $isSelected . "' value='" . $value['main_cat_id'] . "'>" . $value['name'] . "</option>";

edited Mar 12 '18 at 13:51

answered Mar 12 '18 at 13:28

Eddie

26,593
6
36
58

can you also explain the behaviour? – messerbill Mar 12 '18 at 13:30
this is correct, or if you only want one echo, use $output = " – ikdekker Mar 12 '18 at 13:30
@messerbill you can simply not use logic in an echo – ikdekker Mar 12 '18 at 13:31
@ikdekker https://stackoverflow.com/questions/3507042/if-block-inside-echo-statement – messerbill Mar 12 '18 at 13:33
Thanks all for the help! – Muhammad Ahtisham Mar 12 '18 at 13:48
Happy to help @MuhammadAhtisham – Eddie Mar 12 '18 at 13:49

Bhaskar Jain · Answer 2 · 2018-03-12T13:46:38.940

0

try ternary operator:

echo "<option ". $p_main_cat_id==$value['main_cat_id'] ? "selected": ""." value='".$value['main_cat_id']."'>".$value['name']."</option>";

Method 2:

$selected = $p_main_cat_id==$value['main_cat_id'] ? "selected": "";
echo "<option ". $selected." value='".$value['main_cat_id']."'>".$value['name']."</option>";

edited Mar 12 '18 at 13:46

answered Mar 12 '18 at 13:32

Bhaskar Jain

1,651
1
12
20

didn't get any error on console/network but not showing any result in options of select tag. – Muhammad Ahtisham Mar 12 '18 at 13:43

score 0 · Answer 3 · 2018-03-12T14:10:44.383

0

The most readable way is to set variables beforehand, then insert them into a double-quoted string:

extract($value);
$selected = $main_cat_id == $p_main_cat_id ? "selected" : "";
echo "<option $selected value='$main_cat_id'>$name</option>";

edited Mar 12 '18 at 14:10

answered Mar 12 '18 at 13:34

It's in a foreach loop – Muhammad Ahtisham Mar 12 '18 at 13:42
@MuhammadAhtisham Ok? How would that matter? It's most likely table rows being turned into options in a loop, but my code will work in a loop just fine. – Mar 12 '18 at 13:43

CryptoBird · Answer 4 · 2018-03-12T13:59:14.137

0

Here is a simple clean way to do that :

$option = '<option value="' . $value['main_cat_id'] . '" ';

// This is called a ternary operator and it basicaly means :
// If $p_main_cat_id == $value['main_cat_id'] is true then return 'selected >'
// Else return '>'
$option .= ($p_main_cat_id == $value['main_cat_id']) ? 'selected >' : '>';

$option .= $value['name'] . '</option>';

echo $option;

edited Mar 12 '18 at 13:59

answered Mar 12 '18 at 13:47

CryptoBird

508
1
5
22

conditioned string and variable concatenation

4 Answers4