How to pass GET parameters to Retrofit request

Question

I am creating an app with SoundCloud api and trying to append the string value which is entered by user but it showing me null in interface how can I append that in url?

MainActivity.java

  b.setOnClickListener(new View.OnClickListener(){

            @Override
            public void onClick(View p1)
            {
                // TODO: Implement this method
                search = et.getText().toString();
                Log.d("search",search);
                Intent i = new Intent(MainActivity.this, SoundCloud.class);
                i.putExtra("mysearch", search);
                startActivity(i);

                Log.d("CustomUrl",SCService.CustomUrl);
                Toast.makeText(MainActivity.this,""+SCService.CustomUrl,Toast.LENGTH_SHORT).show();


                Retrofit retrofit = new Retrofit.Builder()
                    .baseUrl(Config.API_URL)
                    .addConverterFactory(GsonConverterFactory.create()).build();

                SCService Scservice = retrofit.create(SCService.class);
                Call<Track> call = Scservice.getTrack(search);
                call.enqueue(new Callback<Track>(){

                        @Override
                        public void onResponse(Call<Track> call, Response<Track> response)
                        {
                            // TODO: Implement this method
                            if (response.isSuccessful())
                            {
                                Track track = response.body();
                                streamUrl = track.getStreamUrl();
                                trackname = track.getTitle();
                                Log.e("track", track.getTitle());
                                Toast.makeText(MainActivity.this, trackname, Toast.LENGTH_SHORT).show();
                                Toast.makeText(MainActivity.this, "url" + streamUrl, Toast.LENGTH_SHORT).show();
                                //addToList(trackname);
                            }
                        }

                        @Override
                        public void onFailure(Call<Track> p1, Throwable p2)
                        {
                            // TODO: Implement this method
                            Toast.makeText(MainActivity.this,"error"+p2.getMessage(),Toast.LENGTH_SHORT).show();
                            //showMessage("Network Error: " +  p2.getMessage());
                            Log.d("error", p2.getMessage());
                        }
                    });

            }
        });

ScService.java

public interface SCService
{
    public String CustomUrl = Config.API_URL+"/resolve.json?url="+SoundCloud.SCURL+"&client_id="+Config.CLIENT_ID;
@GET("/resolve.json?url={SCURL}"+"&client_id="+Config.CLIENT_ID)
Call<Track> getTrack(@Path("SCURL")String SCURL);
}

Searched string is in my SoundCloud.java class

    SCURL = receivedmsg.getString("mysearch");
    Log.d("intentdata",SCURL);

    tv.setText("Search Results for " + SCURL);

I want append that SCURL String in GET parameter but it showing me null value for SCURL, how could i achieve this?

Update: I have changed my code as above but got this error

enter code here
  03-15 13:22:14.866 6149 6149 D     search com.sk.scdoenloader                   /https://m.soundcloud.com/dharmaworldwide/houseofcards-mixmaster-05b
  03-15 13:22:14.967 6149 6149 D     CustomUrl com.sk.scdoenloader                https://api.soundcloud.com/resolve.json?url=null&client_id=iZIs9mchVcX5lhVRyQGGAYlNPVldzAoX
  03-15 13:22:15.299 6149 6149 E     AndroidRuntime com.sk.scdoenloader                   FATAL EXCEPTION: main
  03-15 13:22:15.299 6149 6149 E     AndroidRuntime com.sk.scdoenloader           Process: com.sk.scdoenloader, PID: 6149
  03-15 13:22:15.299 6149 6149 E     AndroidRuntime com.sk.scdoenloader           java.lang.IllegalArgumentException: No Retrofit annotation found. (parameter #1)
  03-15 13:22:15.299 6149 6149 E     AndroidRuntime com.sk.scdoenloader           for method SCService.getTrack
  03-15 13:22:15.299 6149 6149 E     AndroidRuntime com.sk.scdoenloader           at retrofit2.ServiceMethod$Builder.methodError(ServiceMethod.java:720)
  03-15 13:22:15.299 6149 6149 E     AndroidRuntime com.sk.scdoenloader           at retrofit2.ServiceMethod$Builder.methodError(ServiceMethod.java:711)
  03-15 13:22:15.299 6149 6149 E     AndroidRuntime com.sk.scdoenloader           at retrofit2.ServiceMethod$Builder.parameterError(ServiceMethod.java:729)
  03-15 13:22:15.299 6149 6149 E     AndroidRuntime com.sk.scdoenloader

may be you are using your variable before it gets its value . — Tejas Pandya, Mar 15 '18 at 07:11
You can use Like : @GET("/resolve.json?url={SCURL}") CallgetAllComments(@Path("SCURL")String SCURL); — matin sayyad, Mar 15 '18 at 07:18
What is receivedmsg ?? In SCURL = receivedmsg.getString("mysearch"); — Nikunj, Mar 15 '18 at 08:00
It's Bundle object for getting string from intent Bundle receivedmsg = getIntent().getExtras(); — shubham kumbhar, Mar 15 '18 at 08:05

score 12 · Answer 1 · edited Mar 15 '18 at 07:16

12

You have to use @Path here

@GET("/resolve.json?url={url}&client_id={clientId}")
Call<Track> getTrack(@Path("url") String url,@Path("clientId") String clientId);

edited Mar 15 '18 at 07:16

Gowthaman M

8,057
8
35
54

answered Mar 15 '18 at 07:11

Ramkumar.M

681
6
21

1

This one is better solution over the other answer using simple string concatenation. – Rohit5k2 Mar 15 '18 at 07:21
Got this errorNo Retrofit annotation found. (parameter #1), I have updated the question, where I have made the mistake? – shubham kumbhar Mar 15 '18 at 07:59
make sure it belongs to the right retrofit package too. In my case I had accidentally imported an annotation from retrofit instead of retrofit2 – Ramkumar.M Mar 15 '18 at 08:08
This is the package i have imported "import retrofit2.http.Path" – shubham kumbhar Mar 15 '18 at 08:16
Are you using proguard? – Ramkumar.M Mar 15 '18 at 08:21
I am using AIDE app, it's included with one progurd file named Proguard-Rules.pro in project directory. – shubham kumbhar Mar 15 '18 at 08:42
that is proguard file. reffer this link http://square.github.io/retrofit/. – Ramkumar.M Mar 15 '18 at 08:57
I have added proguard rules but still not solved the problem :( – shubham kumbhar Mar 15 '18 at 09:09

Santanu Sur · Answer 2 · 2018-03-15T07:18:11.777

6

You can use DYNAMIC URL with retrofit !! (With @Get )

public interface SCService{  
   @GET
   public Call<Track> getTrack(@Url String url);
}

Then you can call with your Custom string url

 service.getTrack("/resolve.json?url="+SoundCloud.SCURL+"&client_id="+ Config.CLIENT_ID + SCURL)

edited Mar 15 '18 at 07:18

answered Mar 15 '18 at 07:12

Santanu Sur

10,997
7
33
52

score 1 · Answer 3 · answered Mar 17 '18 at 11:57

1

What you want here are GET parameters, not path, so use @Query("scurl") String scurl

More details are here

By the way, it's kinda strange (at least in Java) to use all caps for your variable name, scurl is more appropriate than SCURL here

answered Mar 17 '18 at 11:57

ericn

12,476
16
84
127

I used Asynctask now and my project is completed but thanks for your answer i will try this next time, I made that SCURL as static variable so made it uppercase :) – shubham kumbhar Mar 18 '18 at 12:26
I understand that SCURL is a static final of class SoundCloud. However, within the context of `Call getTrack(@Path("SCURL")String SCURL);` method, it's a normal variable and all caps should not be used ;) – ericn Mar 19 '18 at 05:29

score 1 · Answer 4 · answered Aug 12 '19 at 13:33

1

You have to use @Query here

 @GET("Account/RegisterMobileNumber")
 Call<JsonObject> sendSMSToMobileNumber(@Query("mobileNumber") String mobileNumber);

answered Aug 12 '19 at 13:33

Iman Marashi

5,593
38
51

How to pass GET parameters to Retrofit request

4 Answers4

Linked