Programmatically created buttons onclicklistener

Question

I have a loop that creates 34 buttons, how would i set a different onclick for each one?

 while(i<34)
    {
        Button btnTag = new Button(this);
        btnTag.setLayoutParams(new LinearLayout.LayoutParams(LinearLayout.LayoutParams.MATCH_PARENT, LinearLayout.LayoutParams.MATCH_PARENT));
        btnTag.setText(names[i]);
        btnTag.setId(i);
        btnTag.callOnClick();
        layout.addView(btnTag);
        btnTag.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View v) {

                HOW TO MAKE EACH ONE DO A DIFFERENT THING

            }
        });
        i++;
    }

Possible duplicate of [Adding onClick to buttons that are created programmatically](https://stackoverflow.com/questions/33963861/adding-onclick-to-buttons-that-are-created-programmatically) — Somesh Kumar, Mar 15 '18 at 10:47

score 1 · Answer 1 · edited Mar 15 '18 at 11:11

1

You can make different onclick event thanks to v.getId()

while(i<34)
    {
        Button btnTag = new Button(this);
        btnTag.setLayoutParams(new LinearLayout.LayoutParams(LinearLayout.LayoutParams.MATCH_PARENT, LinearLayout.LayoutParams.MATCH_PARENT));
        btnTag.setText(names[i]);
        btnTag.setId(i);
        btnTag.callOnClick();
        layout.addView(btnTag);
        btnTag.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View v) {

                switch(v.getId())
                   {
                      // Your code
                   }

            }
        });
        i++;
    }

edited Mar 15 '18 at 11:11

Niamatullah Bakhshi

1,445
16
27

answered Mar 15 '18 at 10:41

FRED WILLIAMS ASSAMOI

96
6

I am not sure about this, did you check whether this code works or not? – Niamatullah Bakhshi Mar 15 '18 at 10:56
Thanks for the remark @Niamatullah. It was a mistake of copy paste ;) – FRED WILLIAMS ASSAMOI Mar 15 '18 at 11:12

score 0 · Accepted Answer · answered Mar 15 '18 at 10:40

public void createButtons() {
    while(i<34)
    {
        Button btnTag = new Button(this);
        btnTag.setLayoutParams(new LinearLayout.LayoutParams(LinearLayout.LayoutParams.MATCH_PARENT, LinearLayout.LayoutParams.MATCH_PARENT));
        btnTag.setText(names[i]);
        btnTag.setId(i);
        btnTag.setTag("TAG"+i); // set a tag
        btnTag.callOnClick();
        layout.addView(btnTag);
        btnTag.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View v) {
                buttonClicked(v);
            }
        });
        i++;
    }
}

// hand button click
public void buttonClicked(View view) {
    final Object tag = view.getTag();
    if ("TAG1".equals(tag)) {
        //button 1
    } else if ("TAG2".equals(tag)) {
        //button 2
    }
    // add more if else
}

Every button you will create a new OnClickListener object, prefer use one click listener object:

public void createButtons() {
    // just need one listener object
    View.OnClickListener listener = new View.OnClickListener() {
        @Override
        public void onClick(View v) {
            buttonClicked(v);
        }
    };
    while(i<34)
    {
        Button btnTag = new Button(this);
        btnTag.setLayoutParams(new LinearLayout.LayoutParams(LinearLayout.LayoutParams.MATCH_PARENT, LinearLayout.LayoutParams.MATCH_PARENT));
        btnTag.setText(names[i]);
        btnTag.setId(i);
        btnTag.setTag("TAG"+i); // set a tag
        btnTag.callOnClick();
        layout.addView(btnTag);
        btnTag.setOnClickListener(listener);
        i++;
    }
}

score 0 · Answer 3 · answered Mar 15 '18 at 11:06

Though what you are doing isn't practical but Here is what I would Suggest :

Make your activity implements View.OnClickListener

Implement the overrided method inside your activity.

        @override
        public void onClick(View view){
            switch(view.getId()){
// You will have to understand the buttons Ids
                case R.id.buttonId1:
                    MyFunction();
                    break;
                case R.id.buttonId2:
                    MyFunction2();
                    break;
                default:
                    break;

            }

while creating buttons use

button.setOnClickListener(this);

Your Edited Function.

public void createButtons() {
    while(i<34)
    {
        Button btnTag = new Button(this);
        btnTag.setLayoutParams(new LinearLayout.LayoutParams(LinearLayout.LayoutParams.MATCH_PARENT, LinearLayout.LayoutParams.MATCH_PARENT));
        btnTag.setText(names[i]);
        btnTag.setId(i);
        btnTag.setTag("TAG"+i); // set a tag
        btnTag.callOnClick();
        layout.addView(btnTag);
        btnTag.setOnClickListener(this);
        i++;
    }
}

Programmatically created buttons onclicklistener

3 Answers3