update user's data Firebase database

Question

hi i'm trying to update some of user's data username and password

my code below checks if email of current user are exists or not if exists i want to update the old informations with new informations, but my code doesn't work ,it adds me a new user instead of updating user data

update.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View view) {
                progressBar.setVisibility(View.VISIBLE);
                updateUser();
            }
        });


private void updateUser() {
        final DatabaseReference mUser = mDatabase.child("users").child("id");
        mUser.addValueEventListener(new ValueEventListener() {
            @Override
            public void onDataChange(DataSnapshot dataSnapshot) {
                for (DataSnapshot postSnapshot : dataSnapshot.getChildren()) {
                    User user = postSnapshot.getValue(User.class);
                    assert user != null;
                    String emailUser = user.getEmail();
                    if (email.equals(emailUser)) {
                        user.setUsername(name.getText().toString());
                        user.setPassword(newpassword.getText().toString());
                        user.setImageBase64(imageBase64);
                        mUser.setValue(user).addOnCompleteListener(new OnCompleteListener<Void>() {
                            @Override
                            public void onComplete(@NonNull Task<Void> task) {
                                Toast.makeText(getActivity(), "Votre compte a été modifé!", Toast.LENGTH_LONG).show();
                                startActivity(new Intent(getActivity(), LoginActivity.class));
                            }
                        });
                    }
                }
            }

            @Override
            public void onCancelled(DatabaseError databaseError) {

            }
        });
    }

Please read this post on [storing passwords in a database](https://stackoverflow.com/questions/1054022/best-way-to-store-password-in-database). — Frank van Puffelen, Mar 19 '18 at 02:01
@FrankvanPuffelen thanks so much for your comment but my app released for study project i don't need to crypte password or something like this — ali, Mar 19 '18 at 02:03
should look something like this as Frank mentioned. `updateUser('-L7vu-6HqcC_YJW40fYa')`. — Niamatullah Bakhshi, Mar 19 '18 at 02:15
I would suggest to use [Queries](https://firebase.google.com/docs/reference/js/firebase.database.Query) of firebase to retrieve such data. — Niamatullah Bakhshi, Mar 19 '18 at 02:48

score 0 · Answer 1 · answered Mar 19 '18 at 02:03

0

You're calling updateUser("id");. You probably want to call it as updateUser(id);

answered Mar 19 '18 at 02:03

Frank van Puffelen

565,676
79
828
807

score 0 · Answer 2 · answered Mar 19 '18 at 12:05

When you are using this line of code:

mUser.setValue(user)

It means that you are adding a new user under: users/id, it doesn't mean that you are updating that particular user. In order to update a value within a user object, I recommend you using a Map like this:

Map<String, Object> map = new HashMap<>();
map.put("password", newpassword.getText().toString());
mUser.child("-L7vu-6HqcC_YJW40fYa").updateChildren(map);

As you can see, I have used updateChildren() method instead of setValue() and I also have added the child that is missing from your reference.

update user's data Firebase database

2 Answers2