Trying to append List/array based on condition

Question

I'm trying to add to an array based on a condition. Can someone clarify why the if statement isn't working as I intend it to?

all_staff = ["Judith", "Harry", "Jonathan", "Reuben"]
new_staff = []


def person_finder(staff):
for x in staff:
    if x == "Reuben" or "Harry" or "Jonathan":
        new_staff.append(x)
    else:
        continue
    return new_staff


selected = person_finder(all_staff)


def the_men(people):
for x in people:
    print(x + " is a man")


the_men(selected)

This returns:

Judith is a man

Put `new_staff = []` first thing inside `person_finder`. Change `if x == "Reuben" or "Harry" or "Jonathan"` to `if x in ["Reuben", "Harry", "Jonathan"]` — couragewolf, Mar 20 '18 at 12:55

score 2 · Answer 1 · answered Mar 20 '18 at 12:35

2

replace

if x == "Reuben" or "Harry" or "Jonathan":

with

if x == "Reuben" or x == "Harry" or x == "Jonathan":

answered Mar 20 '18 at 12:35

Ramesh-X

4,853
6
46
67

Aaditya Ura · Answer 2 · 2018-03-20T12:55:44.823

1

Change this line :

if x == "Reuben" or "Harry" or "Jonathan":

to

if x == "Reuben" or x=="Harry" or x=="Jonathan":

Working code:

all_staff = ["Judith", "Harry", "Jonathan", "Reuben"]

new_staff = []


def person_finder(staff):
    for x in staff:
        if x == "Reuben" or x=="Harry" or x=="Jonathan":
            new_staff.append(x)
        else:
            continue
    return new_staff


selected = person_finder(all_staff)


def the_men(people):
    for x in people:
        print(x + " is a man")


the_men(selected)

output:

Harry is a man
Jonathan is a man
Reuben is a man

edited Mar 20 '18 at 12:55

answered Mar 20 '18 at 12:35

Aaditya Ura

12,007
7
50
88

This didn't work unfortunately. – Mr Keystrokes Mar 20 '18 at 12:50
@MrKeystrokes its working , check my edited answer. – Aaditya Ura Mar 20 '18 at 12:56

score 1 · Accepted Answer · answered Mar 20 '18 at 12:39

all_staff = ["Judith", "Harry", "Jonathan", "Reuben"]


def person_finder(staff):
    new_staff = []
    for x in staff:
        if x in ["Reuben", "Harry", "Jonathan"]:
            new_staff.append(x)
        else:
            continue
    return new_staff


selected = person_finder(all_staff)


def the_men(people):
    for x in people:
        print(x + " is a man")


the_men(selected)

Trying to append List/array based on condition

3 Answers3