NullPointerException on PostExecute

Question

I tried to display Values on TextView but if I want to populate my TextViews on PostExecute I get a NullPointerException. I already checked if the LIST<ArrayList<Hashmap>> is empty with Log but it is populated.

My code:

public class DBResult extends MainActivity {

    //Erstellen eines JSON Parser Objekts
    JSONParser jParser = new JSONParser();
    ArrayList<HashMap<String,String>> LIST = new ArrayList<>();

    // url to get all products list
    private static String url_dataget = "DATAGET_PHP";

    // JSON Node 
    private static final String TAG_SUCCESS = "success";
    private static final String TAG_PRODUCTS = "products";
    private static final String TAG_NAME = "name";
    private static final String TAG_INN = "inn";
    private static final String TAG_AnalgetikaGroup= "analgetikagroup";
    private static final String TAG_WHOLevel = "wholevel";
    private static final String TAG_DailyDose = "dailydose";
    private static final String TAG_contraindication = "contraindication";
    private static final String TAG_SideEffect = "sideeffect";
    private static final String TAG_GastricProtection = "gastricprotection";


    // products JSONArray
    JSONArray products = null;

    @Override
    public void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);

        //Background Thread
        new LoadMed().execute();

    }
    class LoadMed extends AsyncTask<String,String,String>{
    protected String doInBackground(String...args){

        // Building Parameters
        List<NameValuePair> params = new ArrayList<NameValuePair>();
        // getting JSON string from URL
        JSONObject json = jParser.makeHttpRequest(url_dataget, "GET", params);

        // Check your log cat for JSON reponse
        Log.d("Medic: ", json.toString());

        try {
            // Checking for SUCCESS TAG
            int success = json.getInt(TAG_SUCCESS);
            if (success == 1) {
                // products found
                // Getting Array of Products
                products = json.getJSONArray(TAG_PRODUCTS);

                // looping through All Products
                for (int i = 0; i < products.length(); i++) {
                    JSONObject c = products.getJSONObject(i);

                    // Storing each json item in variable

                    String name = c.getString(TAG_NAME);
                    String INN = c.getString(TAG_INN);
                    String AnalgetikaGroup = c.getString(TAG_AnalgetikaGroup);
                    String WHOLevel = c.getString(TAG_WHOLevel);
                    String DailyDose = c.getString(TAG_DailyDose);
                    String contraindication = c.getString(TAG_contraindication);
                    String SideEffect = c.getString(TAG_SideEffect);
                    String GastricProtection = c.getString(TAG_GastricProtection);
                    HashMap<String,String> map = new HashMap<>();
                    map.put(TAG_NAME,name);
                    map.put(TAG_INN,INN);
                    map.put(TAG_AnalgetikaGroup,AnalgetikaGroup);
                    map.put(TAG_WHOLevel,WHOLevel);
                    map.put(TAG_DailyDose,DailyDose);
                    map.put(TAG_contraindication,contraindication);
                    map.put(TAG_SideEffect,SideEffect);
                    map.put(TAG_GastricProtection,GastricProtection);
                    Log.d("LIL",map.toString());
                    LIST.add(map);





                }
            }
        }catch (JSONException e) {
            e.printStackTrace();
        }
        return null;
    }
     protected void onPostExecute(String file_url) {

        runOnUiThread(new Runnable() {
            public void run() {
                Log.d("sad", LIST.toString());
                TextView mednamefield = findViewById(R.id.medname);
                TextView sideeffectfield = findViewById(R.id.sideeffect);
                TextView medWHOfield = findViewById(R.id.wholevel);
                TextView medGastricProtectionfield = findViewById(R.id.gastricprotecio);
                TextView medINNfield = findViewById(R.id.INN);
                TextView medDailyDosefield = findViewById(R.id.dailydose);
                TextView medanalgeticafield = findViewById(R.id.analgeticagroup);
                TextView contraindicationfield = findViewById(R.id.contraindication);


                mednamefield.setText(LIST.get(0).get(TAG_NAME));
                sideeffectfield.setText(LIST.get(1).get(TAG_SideEffect));
                medWHOfield.setText((LIST.get(2).get(TAG_WHOLevel)));
                medGastricProtectionfield.setText("Magenschutz empfohlen: " + LIST.get(3).get(TAG_GastricProtection));
                contraindicationfield.setText(LIST.get(4).get(TAG_contraindication));
                medINNfield.setText("INN: " + LIST.get(5).get(TAG_INN));
                medDailyDosefield.setText(LIST.get(6).get(TAG_DailyDose));
                medanalgeticafield.setText(LIST.get(7).get(TAG_AnalgetikaGroup));

            }

    });
    }


    }

LOGCAT ERROR:

FATAL EXCEPTION: main
Process: com.example.simon.test123, PID: 4019
java.lang.NullPointerException: Attempt to invoke virtual method 'void android.widget.TextView.setText(java.lang.CharSequence)' on a null object reference
at com.example.simon.test123.DBResult$LoadMed$1.run(DBResult.java:128)
at android.app.Activity.runOnUiThread(Activity.java:5866)
at com.example.simon.test123.DBResult$LoadMed.onPostExecute(DBResult.java:113)
at com.example.simon.test123.DBResult$LoadMed.onPostExecute(DBResult.java:55)
at android.os.AsyncTask.finish(AsyncTask.java:667)
at android.os.AsyncTask.-wrap1(AsyncTask.java)
at android.os.AsyncTask$InternalHandler.handleMessage(AsyncTask.java:684)
at android.os.Handler.dispatchMessage(Handler.java:102)
at android.os.Looper.loop(Looper.java:154)
at android.app.ActivityThread.main(ActivityThread.java:6119)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:886)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:776)

NOTE: I already read the article "What is a NullPointerException" and a few other articles about this topic on stackoverflow but I still can't find the right solution.

Have you figured out which object is `null`, and why is it `null`? — user202729, Mar 21 '18 at 12:05
@Dumbo "I still can't solve it" is not a good enough reason. The OP should pinpoint the problem (which object is `null`, etc.) — user202729, Mar 21 '18 at 12:06
@Dumbo It's a valid flag. They've not defined their layout with `setContentView()`. If you're getting a NPE after `findViewById()`, 99% of the time you're either referencing an ID from a different layout, or omitted the layout alltogether. — Michael Dodd, Mar 21 '18 at 12:07
@user9094494 you can read this [Activity lifecycle](https://developer.android.com/guide/components/activities/activity-lifecycle.html) especially onCreate — Muthukrishnan Rajendran, Mar 21 '18 at 12:09
If you have a different question, ask another question. [Related](https://meta.stackoverflow.com/questions/295359/should-this-edit-be-a-new-question?noredirect=1&lq=1). Remember to try to debug your program first. — user202729, Mar 21 '18 at 12:21
LIST size...just print size like LIST.size(); and tell me or provide your GET url — matin sayyad, Mar 21 '18 at 12:31

Benkerroum Mohamed · Accepted Answer · 2018-03-21T12:24:28.243

2

You need to add : setContentView(R.layout.your_xml); inside onCreate

UPDATE:

for the seceond issue you have, you actually putting the instance map on LIST not the values of the map, you need to do somthing like this instead :

List<String> list = new ArrayList<Sting>(map.values());

edited Mar 21 '18 at 12:24

answered Mar 21 '18 at 12:05

Benkerroum Mohamed

1,867
3
13
19

Thanks for the answer. I fixed this problem and edited my article – ThatOneJavaGuy Mar 21 '18 at 12:15
Check the update – Benkerroum Mohamed Mar 21 '18 at 12:24
1

@user9094494 On this site, questions are not articles. Please ask a different question if you have a different question. – user202729 Mar 21 '18 at 12:29
I can't `List list = new ArrayList(map.values());` because `map` is in the class `LoadMed` – ThatOneJavaGuy Mar 21 '18 at 12:30
As @user202729 said, ask it in a different question, and we'll see – Benkerroum Mohamed Mar 21 '18 at 12:32
Besides, @user9094494 , remember to have a [mcve]. This question is a [too-much-code](http://idownvotedbecau.se/toomuchcode/). – user202729 Mar 21 '18 at 12:34
@user202729 Why should I open a new question if the answer made another error that maybe could be fixed with the help of the guy who wrote the answer ? – ThatOneJavaGuy Mar 21 '18 at 12:35
1

@user9094494 Remember -- [so] is designed not to help individual users, but to create a **repository** of useful questions/answers. Doing that would just clutter up everything, and confuses future visitors. – user202729 Mar 21 '18 at 12:36
@user202729 I understand. I marked the answer as right and I will post another question if I can't solve the other error on my own in the next 2 days. – ThatOneJavaGuy Mar 21 '18 at 12:40
Sorry for that :/ , but just a tip that may help you : you are actually not copying the data from the map to the list, you are pushing the map it self in the list, happy coding :) – Benkerroum Mohamed Mar 21 '18 at 14:38

score 1 · Answer 2 · edited Mar 21 '18 at 12:12

1

You missed setContentView(); in onCreate()

  setContentView(R.layout.your_xml);

onCreate:

@Override
public void onCreate (Bundle savedInstanceState){
    super.onCreate(savedInstanceState);

    setContentView(R.layout.your_xml);

    //Background Thread
    new LoadMed().execute();

}

edited Mar 21 '18 at 12:12

AskNilesh

67,701
16
123
163

answered Mar 21 '18 at 12:08

Venky G

180
7

score 0 · Answer 3 · answered Mar 21 '18 at 12:07

0

you can not add in activity in setContentView Method..

    setContentView(R.layout.layout_issue);//your layout.

answered Mar 21 '18 at 12:07

NullPointerException on PostExecute

3 Answers3