The each() function is deprecated; can't figure out how to change to foreach

Question

<?php
ini_set('error_reporting', E_ALL); // error reporting

// save uploaded files
$i = 1;
while (list ($item, $value) = each ($_FILES)){
    if(substr($item, 0, 11) == 'imageloader'){
        $fileName = $i.'.'.substr($item, 11, 3); // make file name
        move_uploaded_file($value['tmp_name'], $fileName); // save file
        $i++;
    }
}
?>

I need to use foreach. I have tried but it just doesn't work. Can anyone help me change the EACH to a FOREACH loop?

`foreach ($_FILES as $yourvar){ blahblah with $yourvar }` – Lilian Barraud Mar 28 '18 at 13:57 — Lilian Barraud, Mar 28 '18 at 13:57

score 4 · Accepted Answer · answered Mar 28 '18 at 14:21

Change while (list ($item, $value) = each ($_FILES)){

to

foreach( $_FILES as $key => $file ) { }

the syntax above is really old and shouldn't be used.

Moreover you don't get extension properly in order to get extension use

$ext = pathinfo($file['name'], PATHINFO_EXTENSION);

score 0 · Answer 2 · answered Mar 28 '18 at 14:14

these are foreach syntaxes:

foreach (array_expression as $value)
    statement
foreach (array_expression as $key => $value)
    statement

in your case it would be:

<?php
ini_set('error_reporting', E_ALL); // error reporting

// save uploaded files
$i = 1;
foreach ($_FILES as $item => $value)){
    if(substr($item, 0, 11) == 'imageloader'){
        $fileName = $i.'.'.substr($item, 11, 3); // make file name
        move_uploaded_file($value['tmp_name'], $fileName); // save file
        $i++;
    }
}
?>

The each() function is deprecated; can't figure out how to change to foreach

2 Answers2